summaryrefslogtreecommitdiff
path: root/docs/Checkpoint_feedback.txt
blob: a65cc4ecc72d3f6139a19f6b7b8abb63b35a65b8 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
DungeonCrawl

Audrey Fuller (alf9310)
Freya Murphy (tam2214)
Ryan Symons (ras1178)
Yusuf Elsharawy (yse2561)


Very Good progress and Good checkpoint document.  Looking forward to
seeing the final version of the project.

Looks like a significant amount of progress has been made.  Great that
most of the MVP has been achieved and able to move on to some of the
stretch goals.  It is not surprising to have issues with
platform-compatibility or thin-veneer bindings to C libraries.

Good project structure, separating dungeon game state from graphics
and input.  Too bad about Wave Function Collapse not being suitable
for procedural dungeon creation, but Binary-Space Partitioning seems
like a reasonable alternative.

Nice to see lots of documentation in the implementation.  Good to see
lots of `enum` definitions for different components, as well as some
`macro_rules!` to factor out common code.

Excellent to see that most modules have unit tests.  Continue to think
about testing for the final submission.

Look over the rubric for the final project writeup
(https://www.cs.rit.edu/~mtf/teaching/20251/psr/project.html#final_project)
and think about how the features of Rust are used to good effect in
the project.

A little more detail in the Checkpoint would have been good.  Expect
to write a bit more in the Final.


Score: 9.5/10