pic done

src/arch/amd64/idt.S

@@ -1,6 +1,11 @@
 extern idt_exception_handler
 global isr_stub_table
 
+extern idt_pic_timer
+extern idt_pic_keyboard
+extern idt_pic_mouse
+extern idt_pic_eoi
+
 %macro PUSHALL 0
     push rbx
     push rcx
@@ -62,6 +67,49 @@ isr_stub_%+%1:
     iretq
 %endmacro
 
+%macro PICGeneric 1
+isr_stub_%+%1:
+    PUSHALL
+    cld
+    mov rdi, %1
+    call idt_pic_eoi
+    POPALL
+    iretq
+%endmacro
+
+%macro PICTimer 1
+isr_stub_%+%1:
+    PUSHALL
+    cld
+    call idt_pic_timer
+    mov rdi, %1
+    call idt_pic_eoi
+    POPALL
+    iretq
+%endmacro
+
+%macro PICKeyboard 1
+isr_stub_%+%1:
+    PUSHALL
+    cld
+    call idt_pic_keyboard
+    mov rdi, %1
+    call idt_pic_eoi
+    POPALL
+    iretq
+%endmacro
+
+%macro PICMouse 1
+isr_stub_%+%1:
+    PUSHALL
+    cld
+    call idt_pic_mouse
+    mov rdi, %1
+    call idt_pic_eoi
+    POPALL
+    iretq
+%endmacro
+
 ; do nothing
 ; args: interrupt number
 %macro ISRIgnore 1
@@ -107,10 +155,26 @@ ISRExceptionCode 29
 ISRExceptionCode 30
 ISRException 31
 
-%assign i 32
+PICTimer    32 ; 0 
+PICKeyboard 33 ; 1
+PICGeneric  34 ; 2
+PICGeneric  35 ; 3
+PICGeneric  36 ; 4
+PICGeneric  37 ; 5
+PICGeneric  38 ; 6
+PICGeneric  39 ; 7
+PICGeneric  40 ; 8
+PICGeneric  41 ; 9
+PICGeneric  42 ; 10
+PICGeneric  43 ; 11
+PICMouse    44 ; 12
+PICGeneric  45 ; 13
+PICGeneric  46 ; 14
+PICGeneric  47 ; 15
 
 ; ignore other interrupts
-%rep 0x100 - i
+%assign i 48
+%rep 256 - i
     ISRIgnore i
     %assign i i+1
 %endrep

src/arch/amd64/idt.c

@@ -5,6 +5,7 @@
 #include <serial.h>
 
 #include "idt.h"
+#include "pic.h"
 
 #define IDT_SIZE 256
 
@@ -106,6 +107,28 @@ char *EXCEPTIONS[] = {
 	"Exception 0x1F Reserved",
 };
 
+void idt_pic_eoi(uint8_t exception) {
+	pic_eoi(exception - PIC_REMAP_OFFSET);
+}
+
+static size_t timer = 0;
+
+void idt_pic_timer(void) {
+	timer += 1;
+	char buf[20];
+	ltoa(timer, buf, 10);
+	serial_out_str(buf);
+	serial_out_str("\n");
+}
+
+void idt_pic_keyboard(void) {
+	serial_out_str("ps2 kbd");
+}
+
+void idt_pic_mouse(void) {
+	serial_out_str("ps2 mouse");
+}
+
 void idt_exception_handler(uint64_t exception, uint64_t code) {
 	// TODO don't just panic
 	char buf[80];

src/arch/amd64/pic.c

@@ -1,78 +1,89 @@
 #include "bindings.h"
 #include "pic.h"
 
-#define PIC1_COMMAND_PORT 0x20
+#define PIC1            0x20        /* IO base address for master PIC */
-#define PIC1_DATA_PORT 0x21
+#define PIC2            0xA0        /* IO base address for slave PIC */
-#define PIC2_COMMAND_PORT 0xA0
+#define PIC1_COMMAND    PIC1
-#define PIC2_DATA_PORT 0xA1
+#define PIC1_DATA       (PIC1+1)
+#define PIC2_COMMAND    PIC2
+#define PIC2_DATA       (PIC2+1)
+
+#define PIC_EOI         0x20        /* End-of-interrupt command code */
+
+#define ICW1_ICW4       0x01        /* Indicates that ICW4 will be present */
+#define ICW1_SINGLE     0x02        /* Single (cascade) mode */
+#define ICW1_INTERVAL4  0x04        /* Call address interval 4 (8) */
+#define ICW1_LEVEL      0x08        /* Level triggered (edge) mode */
+#define ICW1_INIT       0x10        /* Initialization - required! */
+ 
+#define ICW4_8086       0x01        /* 8086/88 (MCS-80/85) mode */
+#define ICW4_AUTO       0x02        /* Auto (normal) EOI */
+#define ICW4_BUF_SLAVE  0x08        /* Buffered mode/slave */
+#define ICW4_BUF_MASTER 0x0C        /* Buffered mode/master */
+#define ICW4_SFNM       0x10        /* Special fully nested (not) */
 
 void pic_remap(void) {
-	char a1 = inb(PIC1_DATA_PORT);
+	uint8_t a1, a2;
-	char a2 = inb(PIC2_DATA_PORT);
+
-	// control word 1
+	a1 = inb(PIC1_DATA);                        // save masks
-	// 0x11: initialize, enable ICW4
+	a2 = inb(PIC2_DATA);
-	outb(PIC1_COMMAND_PORT, 0x11);
+
+	outb(PIC1_COMMAND, ICW1_INIT | ICW1_ICW4);  // starts the initialization sequence (in cascade mode)
 	io_wait();
-	outb(PIC2_COMMAND_PORT, 0x11);
+	outb(PIC2_COMMAND, ICW1_INIT | ICW1_ICW4);
 	io_wait();
-	// control word 2
+	outb(PIC1_DATA, PIC_REMAP_OFFSET);          // ICW2: Master PIC vector offset
-	// interrupt offset
-	outb(PIC1_DATA_PORT, PIC_REMAP_OFFSET);
 	io_wait();
-	outb(PIC2_DATA_PORT, PIC_REMAP_OFFSET + 8);
+	outb(PIC2_DATA, PIC_REMAP_OFFSET + 8);      // ICW2: Slave PIC vector offset
 	io_wait();
-	// control word 3
+	outb(PIC1_DATA, 4);                         // ICW3: tell Master PIC that there is a slave PIC at IRQ2 (0000 0100)
-	// primary pic: set which pin secondary is connected to
-	// (pin 2)
-	outb(PIC1_DATA_PORT, 0x04);
 	io_wait();
-	outb(PIC2_DATA_PORT, 2);
+	outb(PIC2_DATA, 2);                         // ICW3: tell Slave PIC its cascade identity (0000 0010)
 	io_wait();
-	// control word 3
+
-	// 0x01: enable 8086 mode
+	outb(PIC1_DATA, ICW4_8086);                 // ICW4: have the PICs use 8086 mode (and not 8080 mode)
-	outb(PIC1_DATA_PORT, 0x01);
 	io_wait();
-	outb(PIC2_DATA_PORT, 0x01);
+	outb(PIC2_DATA, ICW4_8086);
 	io_wait();
-	// clear data registers
+
-	outb(PIC1_DATA_PORT, a1);
+	outb(PIC1_DATA, a1);   // restore saved masks.
-	outb(PIC2_DATA_PORT, a2);
+	outb(PIC2_DATA, a2);
 }
 
 void pic_mask(int irq) {
-	uint8_t port;
+	uint16_t port;
+	uint8_t mask;
 	if(irq < 8) {
-		port = PIC1_DATA_PORT;
+		port = PIC1_DATA;
 	} else {
+		port = PIC2_DATA;
 		irq -= 8;
-		port = PIC2_DATA_PORT;
 	}
-	uint8_t mask = inb(port);
+	mask = inb(port) | (1 << irq);
-	outb(port, mask | (1 << irq));
+	outb(port, mask);
 }
 
 void pic_unmask(int irq) {
-	uint8_t port;
+	uint16_t port;
+	uint8_t mask;
 	if(irq < 8) {
-		port = PIC1_DATA_PORT;
+		port = PIC1_DATA;
 	} else {
 		irq -= 8;
-		port = PIC2_DATA_PORT;
+		port = PIC2_DATA;
 	}
-	uint8_t mask = inb(port);
+	mask = inb(port) & ~(1 << irq);
-	outb(port, mask & ~(1 << irq));
+	outb(port, mask);
 }
 
 void pic_disable(void) {
-	outb(PIC1_DATA_PORT, 0xff);
+	outb(PIC1_DATA, 0xff);
-	io_wait();
+	outb(PIC2_DATA, 0xff);
-	outb(PIC2_DATA_PORT, 0xff);
-	io_wait();
 }
 
 void pic_eoi(int irq) {
 	if(irq >= 8) {
-		outb(PIC2_COMMAND_PORT, 0x20);
+		outb(PIC2_COMMAND, PIC_EOI);
 	}
-	outb(PIC1_COMMAND_PORT, 0x20);
+	outb(PIC1_COMMAND, PIC_EOI);
 }

src/arch/amd64/shim.c

@@ -12,12 +12,13 @@
 static struct boot_info boot_info;
 
 void* amd64_shim(void *mboot_data_ptr) {
+	
 	serial_init();
 	paging_init();
-	idt_init();
 	pic_remap();
+	idt_init();
 
-	kmap_page(mboot_data_ptr, mboot_data_ptr, F_WRITEABLE);
+	//kmap_page(mboot_data_ptr, mboot_data_ptr, F_WRITEABLE);
 	
 	struct mboot_info mboot_info;
 	mboot_info = mboot_load_info(mboot_data_ptr);

src/kmain.c

@@ -13,4 +13,8 @@ void kmain(struct boot_info *info) {
 	itoa(*(long*)info, buf, 16);
 	//fb_init(1024, 768);	
 	serial_out_str(buf);
+	while (1) {
+		// loop so we dont halt
+		// this allows interrupts to fire
+	}
 }