clippy my beloved

1 files changed, 19 insertions, 19 deletions

diff --git a/packet/src/record.rs b/packet/src/record.rs
index bc9b694..c7ff1ac 100644
--- a/packet/src/record.rs
+++ b/packet/src/record.rs
@@ -40,7 +40,7 @@ pub enum DnsRecord {
 }
 
 impl DnsRecord {
-    pub fn read(buffer: &mut PacketBuffer) -> Result<DnsRecord> {
+    pub fn read(buffer: &mut PacketBuffer) -> Result<Self> {
         let mut domain = String::new();
         buffer.read_qname(&mut domain)?;
 
@@ -57,10 +57,10 @@ impl DnsRecord {
                     ((raw_addr >> 24) & 0xFF) as u8,
                     ((raw_addr >> 16) & 0xFF) as u8,
                     ((raw_addr >> 8) & 0xFF) as u8,
-                    ((raw_addr >> 0) & 0xFF) as u8,
+                    (raw_addr & 0xFF) as u8,
                 );
 
-                Ok(DnsRecord::A { domain, addr, ttl })
+                Ok(Self::A { domain, addr, ttl })
             }
             QueryType::AAAA => {
                 let raw_addr1 = buffer.read_u32()?;
@@ -69,22 +69,22 @@ impl DnsRecord {
                 let raw_addr4 = buffer.read_u32()?;
                 let addr = Ipv6Addr::new(
                     ((raw_addr1 >> 16) & 0xFFFF) as u16,
-                    ((raw_addr1 >> 0) & 0xFFFF) as u16,
+                    (raw_addr1 & 0xFFFF) as u16,
                     ((raw_addr2 >> 16) & 0xFFFF) as u16,
-                    ((raw_addr2 >> 0) & 0xFFFF) as u16,
+                    (raw_addr2 & 0xFFFF) as u16,
                     ((raw_addr3 >> 16) & 0xFFFF) as u16,
-                    ((raw_addr3 >> 0) & 0xFFFF) as u16,
+                    (raw_addr3 & 0xFFFF) as u16,
                     ((raw_addr4 >> 16) & 0xFFFF) as u16,
-                    ((raw_addr4 >> 0) & 0xFFFF) as u16,
+                    (raw_addr4 & 0xFFFF) as u16,
                 );
 
-                Ok(DnsRecord::AAAA { domain, addr, ttl })
+                Ok(Self::AAAA { domain, addr, ttl })
             }
             QueryType::NS => {
                 let mut ns = String::new();
                 buffer.read_qname(&mut ns)?;
 
-                Ok(DnsRecord::NS {
+                Ok(Self::NS {
                     domain,
                     host: ns,
                     ttl,
@@ -94,7 +94,7 @@ impl DnsRecord {
                 let mut cname = String::new();
                 buffer.read_qname(&mut cname)?;
 
-                Ok(DnsRecord::CNAME {
+                Ok(Self::CNAME {
                     domain,
                     host: cname,
                     ttl,
@@ -105,7 +105,7 @@ impl DnsRecord {
                 let mut mx = String::new();
                 buffer.read_qname(&mut mx)?;
 
-                Ok(DnsRecord::MX {
+                Ok(Self::MX {
                     domain,
                     priority,
                     host: mx,
@@ -115,7 +115,7 @@ impl DnsRecord {
             QueryType::UNKNOWN(_) => {
                 buffer.step(data_len as usize)?;
 
-                Ok(DnsRecord::UNKNOWN {
+                Ok(Self::UNKNOWN {
                     domain,
                     qtype: qtype_num,
                     data_len,
@@ -129,7 +129,7 @@ impl DnsRecord {
         let start_pos = buffer.pos();
 
         match *self {
-            DnsRecord::A {
+            Self::A {
                 ref domain,
                 ref addr,
                 ttl,
@@ -146,7 +146,7 @@ impl DnsRecord {
                 buffer.write_u8(octets[2])?;
                 buffer.write_u8(octets[3])?;
             }
-            DnsRecord::NS {
+            Self::NS {
                 ref domain,
                 ref host,
                 ttl,
@@ -164,7 +164,7 @@ impl DnsRecord {
                 let size = buffer.pos() - (pos + 2);
                 buffer.set_u16(pos, size as u16)?;
             }
-            DnsRecord::CNAME {
+            Self::CNAME {
                 ref domain,
                 ref host,
                 ttl,
@@ -182,7 +182,7 @@ impl DnsRecord {
                 let size = buffer.pos() - (pos + 2);
                 buffer.set_u16(pos, size as u16)?;
             }
-            DnsRecord::MX {
+            Self::MX {
                 ref domain,
                 priority,
                 ref host,
@@ -202,7 +202,7 @@ impl DnsRecord {
                 let size = buffer.pos() - (pos + 2);
                 buffer.set_u16(pos, size as u16)?;
             }
-            DnsRecord::AAAA {
+            Self::AAAA {
                 ref domain,
                 ref addr,
                 ttl,
@@ -217,8 +217,8 @@ impl DnsRecord {
                     buffer.write_u16(*octet)?;
                 }
             }
-            DnsRecord::UNKNOWN { .. } => {
-                println!("Skipping record: {:?}", self);
+            Self::UNKNOWN { .. } => {
+                println!("Skipping record: {self:?}");
             }
         }