From cd10bd2cec36bb8ddfe1d7f825677ca7febff7ce Mon Sep 17 00:00:00 2001
From: Tyler Murphy <tylerm@tylerm.dev>
Date: Wed, 14 Jun 2023 23:56:28 -0400
Subject: fix bug bug fix

---
 client/js/gfx/graphics.js | 51 ++++++++++++++++++++++++++++-------------------
 1 file changed, 31 insertions(+), 20 deletions(-)

(limited to 'client/js/gfx')

diff --git a/client/js/gfx/graphics.js b/client/js/gfx/graphics.js
index 158738c..b406ab1 100644
--- a/client/js/gfx/graphics.js
+++ b/client/js/gfx/graphics.js
@@ -49,29 +49,51 @@ const create_map_dot = (data, x, y) => {
     dot.move(x, y)
     dot.resize(.2,.2)
     dot.show()
+    dot.type = ItemType.DOT
     return dot
 }
 
-const update_item_sprites = (data, sprites) => {
+const draw_sprites = (data, item_sprites) => {
+    let items = data.map.items
 
-    for (const sprite of sprites) {
-        if (sprite !== undefined) {
+    let to_remove = []
+    // remove rendered but non existing items
+    for (const item_key in item_sprites) {
+
+        let sprite = item_sprites[item_key]
+        if (!items[item_key]) {
             sprite.destroy()
+            to_remove.push(item_key)
         }
+
     }
 
-    let item_sprites = {}
+    for (const id of to_remove) {
+        delete item_sprites[id]
+    }
+    
+    // add not rendered sprites
+    for (const item_key in items) {
+
+        /** @type {import('../logic.js').Item} */
+        let item = items[item_key]
+        let sprite = item_sprites[item_key]
+
+        if (sprite) {
+            if (item.type === sprite.type)
+                continue
+            sprite.destroy()
+        }
 
-    for (let item_key in data.map.items) {
-        let item = data.map.items[item_key]
         switch (item.type) {
             case ItemType.DOT:
-                item_sprites[item_key] = create_map_dot(data, item.pos[0], item.pos[1])
+                sprite = create_map_dot(data, ...item.pos)
                 break;
         }
+
+        item_sprites[item_key] = sprite
     }
 
-    return item_sprites
 }
 
 export const startGraphicsUpdater = () => {
@@ -93,18 +115,7 @@ export const startGraphicsUpdater = () => {
             console.log("updating player sprites")
         }
 
-        for (let item_key of data.items_eaten) {
-            if (!(item_sprites[item_key])) continue
-            item_sprites[item_key].destroy()
-            delete item_sprites[item_key]
-            delete data.items_eaten[item_key]
-        }
-
-        if (Object.keys(item_sprites).length !== Object.keys(data.map.items).length) {
-            item_sprites = update_item_sprites(data, item_sprites)
-            console.log("updating item sprites")
-        }
-
+        draw_sprites(data, item_sprites)
         draw_players(data, players, player_sprites)
 
     }
-- 
cgit v1.2.3-freya