summaryrefslogtreecommitdiff
path: root/packages/backend/src/server/api/SkRateLimiterService.ts
blob: 38c97b63df0c788b5e56cef382547e49e5617072 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
/*
 * SPDX-FileCopyrightText: hazelnoot and other Sharkey contributors
 * SPDX-License-Identifier: AGPL-3.0-only
 */

import { Inject, Injectable } from '@nestjs/common';
import Redis from 'ioredis';
import { TimeService } from '@/core/TimeService.js';
import { EnvService } from '@/core/EnvService.js';
import { BucketRateLimit, LegacyRateLimit, LimitInfo, RateLimit, hasMinLimit, isLegacyRateLimit, Keyed, hasMaxLimit, disabledLimitInfo, MaxLegacyLimit, MinLegacyLimit } from '@/misc/rate-limit-utils.js';
import { DI } from '@/di-symbols.js';

@Injectable()
export class SkRateLimiterService {
	private readonly disabled: boolean;

	constructor(
		@Inject(TimeService)
		private readonly timeService: TimeService,

		@Inject(DI.redis)
		private readonly redisClient: Redis.Redis,

		@Inject(EnvService)
		envService: EnvService,
	) {
		this.disabled = envService.env.NODE_ENV === 'test';
	}

	/**
	 * Check & increment a rate limit
	 * @param limit The limit definition
	 * @param actor Client who is calling this limit
	 * @param factor Scaling factor - smaller = larger limit (less restrictive)
	 */
	public async limit(limit: Keyed<RateLimit>, actor: string, factor = 1): Promise<LimitInfo> {
		if (this.disabled || factor === 0) {
			return disabledLimitInfo;
		}

		if (factor < 0) {
			throw new Error(`Rate limit factor is zero or negative: ${factor}`);
		}

		return await this.tryLimit(limit, actor, factor);
	}

	private async tryLimit(limit: Keyed<RateLimit>, actor: string, factor: number): Promise<LimitInfo> {
		if (isLegacyRateLimit(limit)) {
			return await this.limitLegacy(limit, actor, factor);
		} else {
			return await this.limitBucket(limit, actor, factor);
		}
	}

	private async limitLegacy(limit: Keyed<LegacyRateLimit>, actor: string, factor: number): Promise<LimitInfo> {
		if (hasMaxLimit(limit)) {
			return await this.limitLegacyMinMax(limit, actor, factor);
		} else if (hasMinLimit(limit)) {
			return await this.limitLegacyMinOnly(limit, actor, factor);
		} else {
			return disabledLimitInfo;
		}
	}

	private async limitLegacyMinMax(limit: Keyed<MaxLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> {
		if (limit.duration === 0) return disabledLimitInfo;
		if (limit.duration < 0) throw new Error(`Invalid rate limit ${limit.key}: duration is negative (${limit.duration})`);
		if (limit.max < 1) throw new Error(`Invalid rate limit ${limit.key}: max is less than 1 (${limit.max})`);

		// Derive initial dripRate from minInterval OR duration/max.
		const initialDripRate = Math.max(limit.minInterval ?? Math.round(limit.duration / limit.max), 1);

		// Calculate dripSize to reach max at exactly duration
		const dripSize = Math.max(Math.round(limit.max / (limit.duration / initialDripRate)), 1);

		// Calculate final dripRate from dripSize and duration/max
		const dripRate = Math.max(Math.round(limit.duration / (limit.max / dripSize)), 1);

		const bucketLimit: Keyed<BucketRateLimit> = {
			type: 'bucket',
			key: limit.key,
			size: limit.max,
			dripRate,
			dripSize,
		};
		return await this.limitBucket(bucketLimit, actor, factor);
	}

	private async limitLegacyMinOnly(limit: Keyed<MinLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> {
		if (limit.minInterval === 0) return disabledLimitInfo;
		if (limit.minInterval < 0) throw new Error(`Invalid rate limit ${limit.key}: minInterval is negative (${limit.minInterval})`);

		const dripRate = Math.max(Math.round(limit.minInterval), 1);
		const bucketLimit: Keyed<BucketRateLimit> = {
			type: 'bucket',
			key: limit.key,
			size: 1,
			dripRate,
			dripSize: 1,
		};
		return await this.limitBucket(bucketLimit, actor, factor);
	}

	/**
	 * Implementation of Leaky Bucket rate limiting - see SkRateLimiterService.md for details.
	 */
	private async limitBucket(limit: Keyed<BucketRateLimit>, actor: string, factor: number): Promise<LimitInfo> {
		if (limit.size < 1) throw new Error(`Invalid rate limit ${limit.key}: size is less than 1 (${limit.size})`);
		if (limit.dripRate != null && limit.dripRate < 1) throw new Error(`Invalid rate limit ${limit.key}: dripRate is less than 1 (${limit.dripRate})`);
		if (limit.dripSize != null && limit.dripSize < 1) throw new Error(`Invalid rate limit ${limit.key}: dripSize is less than 1 (${limit.dripSize})`);

		// 0 - Calculate
		const now = this.timeService.now;
		const bucketSize = Math.max(Math.ceil(limit.size / factor), 1);
		const dripRate = Math.ceil(limit.dripRate ?? 1000);
		const dripSize = Math.ceil(limit.dripSize ?? 1);
		const expirationSec = Math.max(Math.ceil((dripRate * Math.ceil(bucketSize / dripSize)) / 1000), 1);

		// 1 - Read
		const counterKey = createLimitKey(limit, actor, 'c');
		const timestampKey = createLimitKey(limit, actor, 't');
		const counter = await this.getLimitCounter(counterKey, timestampKey);

		// 2 - Drip
		const dripsSinceLastTick = Math.floor((now - counter.timestamp) / dripRate) * dripSize;
		const deltaCounter = Math.min(dripsSinceLastTick, counter.counter);
		const deltaTimestamp = dripsSinceLastTick * dripRate;
		if (deltaCounter > 0) {
			// Execute the next drip(s)
			const results = await this.executeRedisMulti(
				['get', timestampKey],
				['incrby', timestampKey, deltaTimestamp],
				['expire', timestampKey, expirationSec],
				['get', timestampKey],
				['decrby', counterKey, deltaCounter],
				['expire', counterKey, expirationSec],
				['get', counterKey],
			);
			const expectedTimestamp = counter.timestamp;
			const canaryTimestamp = results[0] ? parseInt(results[0]) : 0;
			counter.timestamp = results[3] ? parseInt(results[3]) : 0;
			counter.counter = results[6] ? parseInt(results[6]) : 0;

			// Check for a data collision and rollback
			if (canaryTimestamp !== expectedTimestamp) {
				const rollbackResults = await this.executeRedisMulti(
					['decrby', timestampKey, deltaTimestamp],
					['get', timestampKey],
					['incrby', counterKey, deltaCounter],
					['get', counterKey],
				);
				counter.timestamp = rollbackResults[1] ? parseInt(rollbackResults[1]) : 0;
				counter.counter = rollbackResults[3] ? parseInt(rollbackResults[3]) : 0;
			}
		}

		// 3 - Check
		const blocked = counter.counter >= bucketSize;
		if (!blocked) {
			if (counter.timestamp === 0) {
				const results = await this.executeRedisMulti(
					['set', timestampKey, now],
					['expire', timestampKey, expirationSec],
					['incr', counterKey],
					['expire', counterKey, expirationSec],
					['get', counterKey],
				);
				counter.timestamp = now;
				counter.counter = results[4] ? parseInt(results[4]) : 0;
			} else {
				const results = await this.executeRedisMulti(
					['incr', counterKey],
					['expire', counterKey, expirationSec],
					['get', counterKey],
				);
				counter.counter = results[2] ? parseInt(results[2]) : 0;
			}
		}

		// Calculate how much time is needed to free up a bucket slot
		const overflow = Math.max((counter.counter + 1) - bucketSize, 0);
		const dripsNeeded = Math.ceil(overflow / dripSize);
		const timeNeeded = Math.max((dripRate * dripsNeeded) - (this.timeService.now - counter.timestamp), 0);

		// Calculate limit status
		const remaining = Math.max(bucketSize - counter.counter, 0);
		const resetMs = timeNeeded;
		const resetSec = Math.ceil(resetMs / 1000);
		const fullResetMs = Math.ceil(counter.counter / dripSize) * dripRate;
		const fullResetSec = Math.ceil(fullResetMs / 1000);
		return { blocked, remaining, resetSec, resetMs, fullResetSec, fullResetMs };
	}

	private async getLimitCounter(counterKey: string, timestampKey: string): Promise<LimitCounter> {
		const [counter, timestamp] = await this.executeRedisMulti(
			['get', counterKey],
			['get', timestampKey],
		);

		return {
			counter: counter ? parseInt(counter) : 0,
			timestamp: timestamp ? parseInt(timestamp) : 0,
		};
	}

	private async executeRedisMulti(...batch: RedisCommand[]): Promise<RedisResult[]> {
		const results = await this.redisClient.multi(batch).exec();

		// Transaction conflict (retryable)
		if (!results) {
			throw new ConflictError('Redis error: transaction conflict');
		}

		// Transaction failed (fatal)
		if (results.length !== batch.length) {
			throw new Error('Redis error: failed to execute batch');
		}

		// Map responses
		const errors: Error[] = [];
		const responses: RedisResult[] = [];
		for (const [error, response] of results) {
			if (error) errors.push(error);
			responses.push(response as RedisResult);
		}

		// Command failed (fatal)
		if (errors.length > 0) {
			const errorMessages = errors
				.map((e, i) => `Error in command ${i}: ${e}`)
				.join('\', \'');
			throw new AggregateError(errors, `Redis error: failed to execute command(s): '${errorMessages}'`);
		}

		return responses;
	}
}

// Not correct, but good enough for the basic commands we use.
type RedisResult = string | null;
type RedisCommand = [command: string, ...args: unknown[]];

function createLimitKey(limit: Keyed<RateLimit>, actor: string, value: string): string {
	return `rl_${actor}_${limit.key}_${value}`;
}

class ConflictError extends Error {}

interface LimitCounter {
	timestamp: number;
	counter: number;
}