From 04e27e160e92d006db59d3285aeaf5c535e82861 Mon Sep 17 00:00:00 2001 From: MeiMei <30769358+mei23@users.noreply.github.com> Date: Sun, 18 Jul 2021 19:57:53 +0900 Subject: 認証の修正 (#7597) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * authenticateのキャッシュを廃止 * 凍結ユーザーがサインイン出来てしまうのを修正 * 凍結ユーザーはストリーミング接続出来ないように * 他人のアクセストークンはrevoke出来ないように, 正常削除を待機するように * ユーザー/アクセストークンを無効化したらストリーミングを切断するように * Revert TODO * ストリーミングterminateは、ユーザー削除後に行うように * signinでsuspendは別のエラーにする * トークン再生成後のストリーミング切断は少し待つように * サスペンド後のストリーミング切断はローカルユーザーのみに --- src/server/api/endpoints/i/delete-account.ts | 4 ++++ src/server/api/endpoints/i/regenerate-token.ts | 7 ++++++- src/server/api/endpoints/i/revoke-token.ts | 9 ++++++++- 3 files changed, 18 insertions(+), 2 deletions(-) (limited to 'src/server/api/endpoints/i') diff --git a/src/server/api/endpoints/i/delete-account.ts b/src/server/api/endpoints/i/delete-account.ts index 0f04c4c92d..f5f0f32a4a 100644 --- a/src/server/api/endpoints/i/delete-account.ts +++ b/src/server/api/endpoints/i/delete-account.ts @@ -3,6 +3,7 @@ import * as bcrypt from 'bcryptjs'; import define from '../../define'; import { Users, UserProfiles } from '../../../../models'; import { doPostSuspend } from '../../../../services/suspend-user'; +import { publishUserEvent } from '@/services/stream'; export const meta = { requireCredential: true as const, @@ -30,4 +31,7 @@ export default define(meta, async (ps, user) => { await doPostSuspend(user).catch(e => {}); await Users.delete(user.id); + + // Terminate streaming + publishUserEvent(user.id, 'terminate', {}); }); diff --git a/src/server/api/endpoints/i/regenerate-token.ts b/src/server/api/endpoints/i/regenerate-token.ts index 3596e20197..3665ed0532 100644 --- a/src/server/api/endpoints/i/regenerate-token.ts +++ b/src/server/api/endpoints/i/regenerate-token.ts @@ -1,6 +1,6 @@ import $ from 'cafy'; import * as bcrypt from 'bcryptjs'; -import { publishMainStream } from '../../../../services/stream'; +import { publishMainStream, publishUserEvent } from '../../../../services/stream'; import generateUserToken from '../../common/generate-native-user-token'; import define from '../../define'; import { Users, UserProfiles } from '../../../../models'; @@ -36,4 +36,9 @@ export default define(meta, async (ps, user) => { // Publish event publishMainStream(user.id, 'myTokenRegenerated'); + + // Terminate streaming + setTimeout(() => { + publishUserEvent(user.id, 'terminate', {}); + }, 5000); }); diff --git a/src/server/api/endpoints/i/revoke-token.ts b/src/server/api/endpoints/i/revoke-token.ts index d71a1bd135..d22d9ca693 100644 --- a/src/server/api/endpoints/i/revoke-token.ts +++ b/src/server/api/endpoints/i/revoke-token.ts @@ -2,6 +2,7 @@ import $ from 'cafy'; import define from '../../define'; import { AccessTokens } from '../../../../models'; import { ID } from '@/misc/cafy-id'; +import { publishUserEvent } from '@/services/stream'; export const meta = { requireCredential: true as const, @@ -19,6 +20,12 @@ export default define(meta, async (ps, user) => { const token = await AccessTokens.findOne(ps.tokenId); if (token) { - AccessTokens.delete(token.id); + await AccessTokens.delete({ + id: ps.tokenId, + userId: user.id, + }); + + // Terminate streaming + publishUserEvent(user.id, 'terminate'); } }); -- cgit v1.2.3-freya