From 2756f553c68082342a784ef716c62da6cea6f3ca Mon Sep 17 00:00:00 2001 From: syuilo Date: Fri, 22 Feb 2019 11:46:58 +0900 Subject: Improve error handling of API (#4345) * wip * wip * wip * Update attached_notes.ts * wip * Refactor * wip * wip * wip * wip * wip * wip * wip * wip * Update call.ts * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * :v: * Fix --- src/server/api/endpoints/admin/moderators/add.ts | 8 ++++---- src/server/api/endpoints/admin/moderators/remove.ts | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/server/api/endpoints/admin/moderators') diff --git a/src/server/api/endpoints/admin/moderators/add.ts b/src/server/api/endpoints/admin/moderators/add.ts index 4b4675c566..58515381d0 100644 --- a/src/server/api/endpoints/admin/moderators/add.ts +++ b/src/server/api/endpoints/admin/moderators/add.ts @@ -24,13 +24,13 @@ export const meta = { } }; -export default define(meta, (ps) => new Promise(async (res, rej) => { +export default define(meta, async (ps) => { const user = await User.findOne({ _id: ps.userId }); if (user == null) { - return rej('user not found'); + throw new Error('user not found'); } await User.update({ @@ -41,5 +41,5 @@ export default define(meta, (ps) => new Promise(async (res, rej) => { } }); - res(); -})); + return; +}); diff --git a/src/server/api/endpoints/admin/moderators/remove.ts b/src/server/api/endpoints/admin/moderators/remove.ts index 2b9da61bb5..75627fb631 100644 --- a/src/server/api/endpoints/admin/moderators/remove.ts +++ b/src/server/api/endpoints/admin/moderators/remove.ts @@ -24,13 +24,13 @@ export const meta = { } }; -export default define(meta, (ps) => new Promise(async (res, rej) => { +export default define(meta, async (ps) => { const user = await User.findOne({ _id: ps.userId }); if (user == null) { - return rej('user not found'); + throw new Error('user not found'); } await User.update({ @@ -41,5 +41,5 @@ export default define(meta, (ps) => new Promise(async (res, rej) => { } }); - res(); -})); + return; +}); -- cgit v1.2.3-freya