From 054220db704a48b5db3066d660a48c09356e916c Mon Sep 17 00:00:00 2001 From: "Acid Chicken (硫酸鶏)" Date: Sun, 14 Apr 2019 17:18:17 +0900 Subject: リファクタリング (#4587) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Use I cap * Avoid _ * Use default value instead of optional boolean * Bye useless variable * Bye verbose try-catch --- src/queue/processors/db/delete-drive-files.ts | 4 +--- src/queue/processors/db/export-blocking.ts | 4 +--- src/queue/processors/db/export-following.ts | 4 +--- src/queue/processors/db/export-mute.ts | 4 +--- src/queue/processors/db/export-notes.ts | 4 +--- 5 files changed, 5 insertions(+), 15 deletions(-) (limited to 'src/queue') diff --git a/src/queue/processors/db/delete-drive-files.ts b/src/queue/processors/db/delete-drive-files.ts index 491734acc6..4e4eab86b7 100644 --- a/src/queue/processors/db/delete-drive-files.ts +++ b/src/queue/processors/db/delete-drive-files.ts @@ -17,10 +17,9 @@ export async function deleteDriveFiles(job: Bull.Job, done: any): Promise } let deletedCount = 0; - let ended = false; let cursor: any = null; - while (!ended) { + while (true) { const files = await DriveFiles.find({ where: { userId: user.id, @@ -33,7 +32,6 @@ export async function deleteDriveFiles(job: Bull.Job, done: any): Promise }); if (files.length === 0) { - ended = true; job.progress(100); break; } diff --git a/src/queue/processors/db/export-blocking.ts b/src/queue/processors/db/export-blocking.ts index 44025ec960..c4b8c9438d 100644 --- a/src/queue/processors/db/export-blocking.ts +++ b/src/queue/processors/db/export-blocking.ts @@ -33,10 +33,9 @@ export async function exportBlocking(job: Bull.Job, done: any): Promise { const stream = fs.createWriteStream(path, { flags: 'a' }); let exportedCount = 0; - let ended = false; let cursor: any = null; - while (!ended) { + while (true) { const blockings = await Blockings.find({ where: { blockerId: user.id, @@ -49,7 +48,6 @@ export async function exportBlocking(job: Bull.Job, done: any): Promise { }); if (blockings.length === 0) { - ended = true; job.progress(100); break; } diff --git a/src/queue/processors/db/export-following.ts b/src/queue/processors/db/export-following.ts index 81dcf8f93e..9fab5bb21a 100644 --- a/src/queue/processors/db/export-following.ts +++ b/src/queue/processors/db/export-following.ts @@ -33,10 +33,9 @@ export async function exportFollowing(job: Bull.Job, done: any): Promise { const stream = fs.createWriteStream(path, { flags: 'a' }); let exportedCount = 0; - let ended = false; let cursor: any = null; - while (!ended) { + while (true) { const followings = await Followings.find({ where: { followerId: user.id, @@ -49,7 +48,6 @@ export async function exportFollowing(job: Bull.Job, done: any): Promise { }); if (followings.length === 0) { - ended = true; job.progress(100); break; } diff --git a/src/queue/processors/db/export-mute.ts b/src/queue/processors/db/export-mute.ts index f810b6ee8d..b957b48b20 100644 --- a/src/queue/processors/db/export-mute.ts +++ b/src/queue/processors/db/export-mute.ts @@ -33,10 +33,9 @@ export async function exportMute(job: Bull.Job, done: any): Promise { const stream = fs.createWriteStream(path, { flags: 'a' }); let exportedCount = 0; - let ended = false; let cursor: any = null; - while (!ended) { + while (true) { const mutes = await Mutings.find({ where: { muterId: user.id, @@ -49,7 +48,6 @@ export async function exportMute(job: Bull.Job, done: any): Promise { }); if (mutes.length === 0) { - ended = true; job.progress(100); break; } diff --git a/src/queue/processors/db/export-notes.ts b/src/queue/processors/db/export-notes.ts index eaa5caf63f..d03a216a59 100644 --- a/src/queue/processors/db/export-notes.ts +++ b/src/queue/processors/db/export-notes.ts @@ -46,10 +46,9 @@ export async function exportNotes(job: Bull.Job, done: any): Promise { }); let exportedNotesCount = 0; - let ended = false; let cursor: any = null; - while (!ended) { + while (true) { const notes = await Notes.find({ where: { userId: user.id, @@ -62,7 +61,6 @@ export async function exportNotes(job: Bull.Job, done: any): Promise { }); if (notes.length === 0) { - ended = true; job.progress(100); break; } -- cgit v1.2.3-freya