From 861302f0fd2c47d78f6b9c78697a649fcf1342c8 Mon Sep 17 00:00:00 2001 From: syuilo Date: Tue, 5 Feb 2019 03:51:54 +0900 Subject: アニメーション画像を無効にする際、サーバーサイドではなくクライアントサイドでURLを変更するように MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/models/drive-file.ts | 10 +--------- src/models/note.ts | 10 +++------- src/models/user.ts | 10 ++-------- 3 files changed, 6 insertions(+), 24 deletions(-) (limited to 'src/models') diff --git a/src/models/drive-file.ts b/src/models/drive-file.ts index e788ac2b2f..62a544c214 100644 --- a/src/models/drive-file.ts +++ b/src/models/drive-file.ts @@ -1,11 +1,10 @@ import * as mongo from 'mongodb'; import * as deepcopy from 'deepcopy'; import { pack as packFolder } from './drive-folder'; -import { pack as packUser, IUser } from './user'; +import { pack as packUser } from './user'; import monkDb, { nativeDbConn, dbLogger } from '../db/mongodb'; import isObjectId from '../misc/is-objectid'; import getDriveFileUrl, { getOriginalUrl } from '../misc/get-drive-file-url'; -import wrapUrl from '../misc/wrap-url'; const DriveFile = monkDb.get('driveFiles.files'); DriveFile.createIndex('md5'); @@ -134,7 +133,6 @@ export const packMany = ( detail?: boolean self?: boolean, withUser?: boolean, - me?: string | mongo.ObjectID | IUser, } ) => { return Promise.all(files.map(f => pack(f, options))); @@ -149,7 +147,6 @@ export const pack = ( detail?: boolean, self?: boolean, withUser?: boolean, - me?: string | mongo.ObjectID | IUser, } ) => new Promise(async (resolve, reject) => { const opts = Object.assign({ @@ -192,11 +189,6 @@ export const pack = ( _target.url = getDriveFileUrl(_file); _target.thumbnailUrl = getDriveFileUrl(_file, true); - - if (_target.thumbnailUrl != null) { - _target.thumbnailUrl = wrapUrl(_target.thumbnailUrl, options.me); - } - _target.isRemote = _file.metadata.isRemote; if (_target.properties == null) _target.properties = {}; diff --git a/src/models/note.ts b/src/models/note.ts index b1031d3e9b..352de4f8d6 100644 --- a/src/models/note.ts +++ b/src/models/note.ts @@ -11,7 +11,6 @@ import Reaction from './note-reaction'; import { packMany as packFileMany, IDriveFile } from './drive-file'; import Following from './following'; import Emoji from './emoji'; -import wrapUrl from '../misc/wrap-url'; const Note = db.get('notes'); Note.createIndex('uri', { sparse: true, unique: true }); @@ -248,14 +247,11 @@ export const pack = async ( fields: { _id: false } }); } else { - _note.emojis = (await Emoji.find({ + _note.emojis = Emoji.find({ name: { $in: _note.emojis }, host: host }, { fields: { _id: false } - })).map(emoji => async () => { - emoji.url = await wrapUrl(emoji.url, me); - return emoji; }); } } @@ -278,7 +274,7 @@ export const pack = async ( if (_note.geo) delete _note.geo.type; // Populate user - _note.user = packUser(_note.userId, me); + _note.user = packUser(_note.userId, meId); // Populate app if (_note.appId) { @@ -286,7 +282,7 @@ export const pack = async ( } // Populate files - _note.files = packFileMany(_note.fileIds || [], { me }); + _note.files = packFileMany(_note.fileIds || []); // Some counts _note.renoteCount = _note.renoteCount || 0; diff --git a/src/models/user.ts b/src/models/user.ts index cba1d98c46..2453a2ed15 100644 --- a/src/models/user.ts +++ b/src/models/user.ts @@ -12,7 +12,6 @@ import config from '../config'; import FollowRequest from './follow-request'; import fetchMeta from '../misc/fetch-meta'; import Emoji from './emoji'; -import wrapUrl from '../misc/wrap-url'; const User = db.get('users'); @@ -345,8 +344,6 @@ export const pack = ( if (_user.avatarUrl == null) { _user.avatarUrl = `${config.drive_url}/default-avatar.jpg`; - } else { - _user.avatarUrl = wrapUrl(_user.avatarUrl, me); } if (!meId || !meId.equals(_user.id) || !opts.detail) { @@ -371,7 +368,7 @@ export const pack = ( if (opts.detail) { if (_user.pinnedNoteIds) { // Populate pinned notes - _user.pinnedNotes = packNoteMany(_user.pinnedNoteIds, me, { + _user.pinnedNotes = packNoteMany(_user.pinnedNoteIds, meId, { detail: true }); } @@ -400,14 +397,11 @@ export const pack = ( // カスタム絵文字添付 if (_user.emojis) { - _user.emojis = (await Emoji.find({ + _user.emojis = Emoji.find({ name: { $in: _user.emojis }, host: _user.host }, { fields: { _id: false } - })).map(emoji => { - emoji.url = wrapUrl(emoji.url, me); - return emoji; }); } -- cgit v1.2.3-freya