From b5a1fdd4c7597ebdd4ab6022e189da9ca3451dbb Mon Sep 17 00:00:00 2001 From: syuilo Date: Mon, 27 Jul 2020 08:46:21 +0900 Subject: refactor(client): Do not mutate prop directly Related #6595 --- src/client/scripts/paging.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src/client/scripts/paging.ts') diff --git a/src/client/scripts/paging.ts b/src/client/scripts/paging.ts index 832f0720e0..006d23875c 100644 --- a/src/client/scripts/paging.ts +++ b/src/client/scripts/paging.ts @@ -74,10 +74,6 @@ export default (opts) => ({ }, methods: { - updateItem(i, item) { - Vue.set((this as any).items, i, item); - }, - reload() { this.items = []; this.init(); @@ -94,6 +90,9 @@ export default (opts) => ({ ...params, limit: this.pagination.noPaging ? (this.pagination.limit || 10) : (this.pagination.limit || 10) + 1, }).then(items => { + for (const item of items) { + Object.freeze(item); + } if (!this.pagination.noPaging && (items.length > (this.pagination.limit || 10))) { items.pop(); this.items = this.pagination.reversed ? [...items].reverse() : items; @@ -130,6 +129,9 @@ export default (opts) => ({ untilId: this.items[this.items.length - 1].id, }), }).then(items => { + for (const item of items) { + Object.freeze(item); + } if (items.length > SECOND_FETCH_LIMIT) { items.pop(); this.items = this.pagination.reversed ? [...items].reverse().concat(this.items) : this.items.concat(items); -- cgit v1.2.3-freya