From fc4599ec07bb8def91fedf5afa9bb469bb54362a Mon Sep 17 00:00:00 2001 From: Hazelnoot Date: Sun, 8 Dec 2024 12:02:58 -0500 Subject: fix rate limit scaling (it's no longer inverted) --- packages/backend/src/server/api/SkRateLimiterService.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'packages/backend/src/server/api') diff --git a/packages/backend/src/server/api/SkRateLimiterService.ts b/packages/backend/src/server/api/SkRateLimiterService.ts index d9abbfd406..1aee8aa799 100644 --- a/packages/backend/src/server/api/SkRateLimiterService.ts +++ b/packages/backend/src/server/api/SkRateLimiterService.ts @@ -95,7 +95,7 @@ export class SkRateLimiterService { if (limit.minInterval < 0) throw new Error(`Invalid rate limit ${limit.key}: minInterval is negative (${limit.minInterval})`); const counter = await this.getLimitCounter(limit, actor, 'min'); - const minInterval = Math.max(Math.ceil(limit.minInterval / factor), 0); + const minInterval = Math.max(Math.ceil(limit.minInterval * factor), 0); // Update expiration if (counter.c > 0) { @@ -132,7 +132,7 @@ export class SkRateLimiterService { if (limit.dripSize != null && limit.dripSize < 1) throw new Error(`Invalid rate limit ${limit.key}: dripSize is less than 1 (${limit.dripSize})`); const counter = await this.getLimitCounter(limit, actor, 'bucket'); - const bucketSize = Math.max(Math.ceil(limit.size * factor), 1); + const bucketSize = Math.max(Math.ceil(limit.size / factor), 1); const dripRate = Math.ceil(limit.dripRate ?? 1000); const dripSize = Math.ceil(limit.dripSize ?? 1); -- cgit v1.2.3-freya