summaryrefslogtreecommitdiff
path: root/packages/backend/src/queue/processors/SystemWebhookDeliverProcessorService.ts
diff options
context:
space:
mode:
Diffstat (limited to 'packages/backend/src/queue/processors/SystemWebhookDeliverProcessorService.ts')
-rw-r--r--packages/backend/src/queue/processors/SystemWebhookDeliverProcessorService.ts12
1 files changed, 4 insertions, 8 deletions
diff --git a/packages/backend/src/queue/processors/SystemWebhookDeliverProcessorService.ts b/packages/backend/src/queue/processors/SystemWebhookDeliverProcessorService.ts
index f6bef52684..f9fcd1e928 100644
--- a/packages/backend/src/queue/processors/SystemWebhookDeliverProcessorService.ts
+++ b/packages/backend/src/queue/processors/SystemWebhookDeliverProcessorService.ts
@@ -12,6 +12,7 @@ import type Logger from '@/logger.js';
import { HttpRequestService } from '@/core/HttpRequestService.js';
import { StatusError } from '@/misc/status-error.js';
import { bindThis } from '@/decorators.js';
+import { renderInlineError } from '@/misc/render-inline-error.js';
import { QueueLoggerService } from '../QueueLoggerService.js';
import { SystemWebhookDeliverJobData } from '../types.js';
@@ -63,21 +64,16 @@ export class SystemWebhookDeliverProcessorService {
return 'Success';
} catch (res) {
- this.logger.error(res as Error);
+ this.logger.error(`Failed to send webhook: ${renderInlineError(res)}`);
this.systemWebhooksRepository.update({ id: job.data.webhookId }, {
latestSentAt: new Date(),
latestStatus: res instanceof StatusError ? res.statusCode : 1,
});
- if (res instanceof StatusError) {
+ if (res instanceof StatusError && !res.isRetryable) {
// 4xx
- if (!res.isRetryable) {
- throw new Bull.UnrecoverableError(`${res.statusCode} ${res.statusMessage}`);
- }
-
- // 5xx etc.
- throw new Error(`${res.statusCode} ${res.statusMessage}`);
+ throw new Bull.UnrecoverableError(`${res.statusCode} ${res.statusMessage}`);
} else {
// DNS error, socket error, timeout ...
throw res;