diff options
| author | Kagami Sascha Rosylight <saschanaz@outlook.com> | 2023-08-13 14:22:57 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-13 21:22:57 +0900 |
| commit | ab58b651f79e182c20a238f9c07f0c0006a58599 (patch) | |
| tree | 185019db8852cfe649481dbce817fc4ae2d935d0 /packages/frontend/src/scripts | |
| parent | enhance(frontend): tweak user moderation page (diff) | |
| download | sharkey-ab58b651f79e182c20a238f9c07f0c0006a58599.tar.gz sharkey-ab58b651f79e182c20a238f9c07f0c0006a58599.tar.bz2 sharkey-ab58b651f79e182c20a238f9c07f0c0006a58599.zip | |
fix(frontend/scroll): no callback for disconnected elements (#11714)
* fix(frontend/scroll): no callback for disconnected elements
* Update CHANGELOG.md
Diffstat (limited to 'packages/frontend/src/scripts')
| -rw-r--r-- | packages/frontend/src/scripts/scroll.ts | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/packages/frontend/src/scripts/scroll.ts b/packages/frontend/src/scripts/scroll.ts index b2b2c41dcf..7338de62b6 100644 --- a/packages/frontend/src/scripts/scroll.ts +++ b/packages/frontend/src/scripts/scroll.ts @@ -30,7 +30,7 @@ export function getScrollPosition(el: HTMLElement | null): number { export function onScrollTop(el: HTMLElement, cb: () => unknown, tolerance = 1, once = false) { // とりあえず評価してみる - if (isTopVisible(el)) { + if (el.isConnected && isTopVisible(el)) { cb(); if (once) return null; } @@ -54,7 +54,7 @@ export function onScrollBottom(el: HTMLElement, cb: () => unknown, tolerance = 1 const container = getScrollContainer(el); // とりあえず評価してみる - if (isBottomVisible(el, tolerance, container)) { + if (el.isConnected && isBottomVisible(el, tolerance, container)) { cb(); if (once) return null; } |