summaryrefslogtreecommitdiff
path: root/packages/backend/test/unit/server
diff options
context:
space:
mode:
authorHazelnoot <acomputerdog@gmail.com>2024-12-08 12:02:58 -0500
committerHazelnoot <acomputerdog@gmail.com>2024-12-08 12:02:58 -0500
commitfc4599ec07bb8def91fedf5afa9bb469bb54362a (patch)
treeaad248e19cd4fbf7088c35df7e77756e805422ec /packages/backend/test/unit/server
parentbypass rate limits when factor is 0 (diff)
downloadsharkey-fc4599ec07bb8def91fedf5afa9bb469bb54362a.tar.gz
sharkey-fc4599ec07bb8def91fedf5afa9bb469bb54362a.tar.bz2
sharkey-fc4599ec07bb8def91fedf5afa9bb469bb54362a.zip
fix rate limit scaling (it's no longer inverted)
Diffstat (limited to 'packages/backend/test/unit/server')
-rw-r--r--packages/backend/test/unit/server/api/SkRateLimiterServiceTests.ts10
1 files changed, 5 insertions, 5 deletions
diff --git a/packages/backend/test/unit/server/api/SkRateLimiterServiceTests.ts b/packages/backend/test/unit/server/api/SkRateLimiterServiceTests.ts
index c7fac85706..910a3e5582 100644
--- a/packages/backend/test/unit/server/api/SkRateLimiterServiceTests.ts
+++ b/packages/backend/test/unit/server/api/SkRateLimiterServiceTests.ts
@@ -274,8 +274,8 @@ describe(SkRateLimiterService, () => {
it('should scale limit by factor', async () => {
counter = { c: 1, t: 0 };
- const i1 = await serviceUnderTest().limit(limit, actor, 2); // 1 + 1 = 2
- const i2 = await serviceUnderTest().limit(limit, actor, 2); // 2 + 1 = 3
+ const i1 = await serviceUnderTest().limit(limit, actor, 0.5); // 1 + 1 = 2
+ const i2 = await serviceUnderTest().limit(limit, actor, 0.5); // 2 + 1 = 3
expect(i1.blocked).toBeFalsy();
expect(i2.blocked).toBeTruthy();
@@ -514,7 +514,7 @@ describe(SkRateLimiterService, () => {
minCounter = { c: 1, t: 0 };
mockTimeService.now += 500;
- const info = await serviceUnderTest().limit(limit, actor, 2);
+ const info = await serviceUnderTest().limit(limit, actor, 0.5);
expect(info.blocked).toBeFalsy();
});
@@ -657,7 +657,7 @@ describe(SkRateLimiterService, () => {
it('should scale limit by factor', async () => {
counter = { c: 10, t: 0 };
- const info = await serviceUnderTest().limit(limit, actor, 2); // 10 + 1 = 11
+ const info = await serviceUnderTest().limit(limit, actor, 0.5); // 10 + 1 = 11
expect(info.blocked).toBeTruthy();
});
@@ -825,7 +825,7 @@ describe(SkRateLimiterService, () => {
minCounter = { c: 1, t: 0 };
mockTimeService.now += 500;
- const info = await serviceUnderTest().limit(limit, actor, 2);
+ const info = await serviceUnderTest().limit(limit, actor, 0.5);
expect(info.blocked).toBeFalsy();
});