only attach file extension for browser-safe file types

1 files changed, 18 insertions, 4 deletions

diff --git a/packages/backend/src/core/DriveService.ts b/packages/backend/src/core/DriveService.ts
index 99e0ea98dd..734ce6b88f 100644
--- a/packages/backend/src/core/DriveService.ts
+++ b/packages/backend/src/core/DriveService.ts
@@ -148,7 +148,6 @@ export class DriveService {
 	@bindThis
 	private async save(file: MiDriveFile, path: string, name: string, info: FileInfo): Promise<MiDriveFile> {
 		const type = info.type.mime;
-		const ext = info.type.ext;
 		const hash = info.md5;
 		const size = info.size;
 
@@ -228,9 +227,11 @@ export class DriveService {
 
 			return await this.driveFilesRepository.insertOne(file);
 		} else { // use internal storage
-			const accessKey = `${randomUUID()}.${ext}`;
-			const thumbnailAccessKey = `thumbnail-${randomUUID()}.${ext}`;
-			const webpublicAccessKey = `webpublic-${randomUUID()}.${ext}`;
+			const ext = FILE_TYPE_BROWSERSAFE.includes(type) ? info.type.ext : null;
+
+			const accessKey = makeFileKey(ext);
+			const thumbnailAccessKey = makeFileKey(ext, 'thumbnail');
+			const webpublicAccessKey = makeFileKey(ext, 'webpublic');
 
 			// Ugly type is just to help TS figure out that 2nd / 3rd promises are optional.
 			const promises: [Promise<string>, ...(Promise<string> | undefined)[]] = [
@@ -867,3 +868,16 @@ export class DriveService {
 		}
 	}
 }
+
+function makeFileKey(ext: string | null, prefix?: string): string {
+	const parts: string[] = [randomUUID()];
+
+	if (prefix) {
+		parts.unshift(prefix, '-');
+	}
+	if (ext) {
+		parts.push('.', ext);
+	}
+
+	return parts.join('');
+}