summaryrefslogtreecommitdiff
path: root/packages/backend/src/server
diff options
context:
space:
mode:
authorMarie <github@yuugi.dev>2025-02-18 23:27:56 +0000
committerMarie <github@yuugi.dev>2025-02-18 23:27:56 +0000
commitd67eefaaf5639ec5be3cb3ade76e0533af869cd1 (patch)
tree0df3a86df7496df4568e8bfff6ac33000184864d /packages/backend/src/server
parentmerge: fix time zone for CustomEmojiService test (!909) (diff)
parentimplement redisForRateLimit (diff)
downloadsharkey-d67eefaaf5639ec5be3cb3ade76e0533af869cd1.tar.gz
sharkey-d67eefaaf5639ec5be3cb3ade76e0533af869cd1.tar.bz2
sharkey-d67eefaaf5639ec5be3cb3ade76e0533af869cd1.zip
merge: Add separate redis for rate limit (!908)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/908 Approved-by: dakkar <dakkar@thenautilus.net> Approved-by: Marie <github@yuugi.dev>
Diffstat (limited to 'packages/backend/src/server')
-rw-r--r--packages/backend/src/server/SkRateLimiterService.md1
-rw-r--r--packages/backend/src/server/SkRateLimiterService.ts2
2 files changed, 2 insertions, 1 deletions
diff --git a/packages/backend/src/server/SkRateLimiterService.md b/packages/backend/src/server/SkRateLimiterService.md
index fb007538fa..c8a2b4e85c 100644
--- a/packages/backend/src/server/SkRateLimiterService.md
+++ b/packages/backend/src/server/SkRateLimiterService.md
@@ -39,6 +39,7 @@ The first call is read-only, while the others perform at least one write operati
Two integer keys are stored per client/subject, and both expire together after the maximum duration of the limit.
While performance has not been formally tested, it's expected that SkRateLimiterService has an impact roughly on par with the legacy RateLimiterService.
Redis memory usage should be notably lower due to the reduced number of keys and avoidance of set / array constructions.
+If redis load does become a concern, then a dedicated node can be assigned via the `redisForRateLimit` config setting.
## Concurrency and Multi-Node Correctness
diff --git a/packages/backend/src/server/SkRateLimiterService.ts b/packages/backend/src/server/SkRateLimiterService.ts
index 038f12cb25..30bf092e4f 100644
--- a/packages/backend/src/server/SkRateLimiterService.ts
+++ b/packages/backend/src/server/SkRateLimiterService.ts
@@ -27,7 +27,7 @@ export class SkRateLimiterService {
@Inject('TimeService')
private readonly timeService: TimeService,
- @Inject(DI.redis)
+ @Inject(DI.redisForRateLimit)
private readonly redisClient: Redis.Redis,
@Inject('RoleService')