summaryrefslogtreecommitdiff
path: root/packages/backend/src/server/api
diff options
context:
space:
mode:
authoryukineko <27853966+hideki0403@users.noreply.github.com>2023-11-03 14:54:28 +0900
committerGitHub <noreply@github.com>2023-11-03 14:54:28 +0900
commit025ae436b5fcb0a019962807f0f79068f135038f (patch)
tree577ca4e2022fa1d7c8bbd8deda4478a1db304532 /packages/backend/src/server/api
parentupdate deps (diff)
downloadsharkey-025ae436b5fcb0a019962807f0f79068f135038f.tar.gz
sharkey-025ae436b5fcb0a019962807f0f79068f135038f.tar.bz2
sharkey-025ae436b5fcb0a019962807f0f79068f135038f.zip
enhance: アカウント登録時のメールアドレス認証に30分の有効期限を設定 (#12221)
* add: metaにemailVerificationExpiresInを追加 * enhance: 招待コード使用時, メアド認証時に認証期限を確認するように * add: クライアント側に実装 * update: CHANGELOG.md * add: コメントを追加 * Revert "add: metaにemailVerificationExpiresInを追加" This reverts commit ceb6ccff51a406bfd87b4da6c59401ce5551dd95. * Revert "add: コメントを追加" This reverts commit 7ee301c3eed4ded295490a6614650a3720317772. * change(client): メール認証の有効期限を30分で固定するように変更 * change(backend): メール認証の有効期限を30分で固定するように変更 * update: CHANGELOG.md
Diffstat (limited to 'packages/backend/src/server/api')
-rw-r--r--packages/backend/src/server/api/SignupApiService.ts19
1 files changed, 18 insertions, 1 deletions
diff --git a/packages/backend/src/server/api/SignupApiService.ts b/packages/backend/src/server/api/SignupApiService.ts
index d2c4440116..d6f4df7f13 100644
--- a/packages/backend/src/server/api/SignupApiService.ts
+++ b/packages/backend/src/server/api/SignupApiService.ts
@@ -136,7 +136,20 @@ export class SignupApiService {
return;
}
- if (ticket.usedAt) {
+ // メアド認証が有効の場合
+ if (instance.emailRequiredForSignup) {
+ // メアド認証済みならエラー
+ if (ticket.usedBy) {
+ reply.code(400);
+ return;
+ }
+
+ // 認証しておらず、メール送信から30分以内ならエラー
+ if (ticket.usedAt && ticket.usedAt.getTime() + (1000 * 60 * 30) > Date.now()) {
+ reply.code(400);
+ return;
+ }
+ } else if (ticket.usedAt) {
reply.code(400);
return;
}
@@ -224,6 +237,10 @@ export class SignupApiService {
try {
const pendingUser = await this.userPendingsRepository.findOneByOrFail({ code });
+ if (this.idService.parse(pendingUser.id).date.getTime() + (1000 * 60 * 30) < Date.now()) {
+ throw new FastifyReplyError(400, 'EXPIRED');
+ }
+
const { account, secret } = await this.signupService.signup({
username: pendingUser.username,
passwordHash: pendingUser.password,