diff options
| author | yukineko <27853966+hideki0403@users.noreply.github.com> | 2023-10-24 14:34:32 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-24 14:34:32 +0900 |
| commit | 0c730968a363482a36f20ddec0a77eef1fd8639e (patch) | |
| tree | cfa20b4e195cb5da146e5ce7fcad7ddf9c52d0a6 /packages/backend/src/server/api/endpoints/notes/hybrid-timeline.ts | |
| parent | ci: fix pullreq number may not get correctly (#12127) (diff) | |
| download | sharkey-0c730968a363482a36f20ddec0a77eef1fd8639e.tar.gz sharkey-0c730968a363482a36f20ddec0a77eef1fd8639e.tar.bz2 sharkey-0c730968a363482a36f20ddec0a77eef1fd8639e.zip | |
fix: RedisへのTLキャッシュが有効の場合にHTL/LTL/STL/リストが空になることがある問題を修正 (#12088) (#12124)
* fix: RedisTimelineが有効の場合にHTLがリセットされた状態になる問題を修正
* add: CHANGELOG.md
* fix: LTL, STLでもTLが空になることがある問題を修正
* update: CHANGELOG.md
* fix: DBへのフォールバック時にwithRenotesが考慮されていないのを修正
* feat: リストにもDBフォールバックを実装
* fix: リストのDBフォールバック時の挙動を修正
---------
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Diffstat (limited to 'packages/backend/src/server/api/endpoints/notes/hybrid-timeline.ts')
| -rw-r--r-- | packages/backend/src/server/api/endpoints/notes/hybrid-timeline.ts | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/packages/backend/src/server/api/endpoints/notes/hybrid-timeline.ts b/packages/backend/src/server/api/endpoints/notes/hybrid-timeline.ts index 518c34b949..7d0c9f1185 100644 --- a/packages/backend/src/server/api/endpoints/notes/hybrid-timeline.ts +++ b/packages/backend/src/server/api/endpoints/notes/hybrid-timeline.ts @@ -131,6 +131,8 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- shouldFallbackToDb = shouldFallbackToDb || (noteIds.length === 0); + let redisTimeline: MiNote[] = []; + if (!shouldFallbackToDb) { const query = this.notesRepository.createQueryBuilder('note') .where('note.id IN (:...noteIds)', { noteIds: noteIds }) @@ -141,9 +143,9 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- .leftJoinAndSelect('renote.user', 'renoteUser') .leftJoinAndSelect('note.channel', 'channel'); - let timeline = await query.getMany(); + redisTimeline = await query.getMany(); - timeline = timeline.filter(note => { + redisTimeline = redisTimeline.filter(note => { if (note.userId === me.id) { return true; } @@ -159,15 +161,15 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- return true; }); - // TODO: フィルタした結果件数が足りなかった場合の対応 - - timeline.sort((a, b) => a.id > b.id ? -1 : 1); + redisTimeline.sort((a, b) => a.id > b.id ? -1 : 1); + } + if (redisTimeline.length > 0) { process.nextTick(() => { this.activeUsersChart.read(me); }); - return await this.noteEntityService.packMany(timeline, me); + return await this.noteEntityService.packMany(redisTimeline, me); } else { // fallback to db return await this.getFromDb({ untilId, |