diff options
| author | okayurisotto <okayurisotto@proton.me> | 2023-07-11 14:58:58 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-11 14:58:58 +0900 |
| commit | cf3e39178b4180bfc5f57b8bb766faf5b5fc99b9 (patch) | |
| tree | 40d7b3daa5a02d715fc82528cc060df4744c46f2 /packages/backend/src/server/api/endpoints/i/read-announcement.ts | |
| parent | chore(frontend): Remove experimental flag from migration feature (diff) | |
| download | sharkey-cf3e39178b4180bfc5f57b8bb766faf5b5fc99b9.tar.gz sharkey-cf3e39178b4180bfc5f57b8bb766faf5b5fc99b9.tar.bz2 sharkey-cf3e39178b4180bfc5f57b8bb766faf5b5fc99b9.zip | |
refactor(backend): 存在確認の`findOneBy`を`exist`に置き換え (#11224)
* refactor(backend): 存在確認の`findOneBy`を`exist`に置き換え
* cleanup
Diffstat (limited to 'packages/backend/src/server/api/endpoints/i/read-announcement.ts')
| -rw-r--r-- | packages/backend/src/server/api/endpoints/i/read-announcement.ts | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/packages/backend/src/server/api/endpoints/i/read-announcement.ts b/packages/backend/src/server/api/endpoints/i/read-announcement.ts index b8922b91e5..352fe54c5d 100644 --- a/packages/backend/src/server/api/endpoints/i/read-announcement.ts +++ b/packages/backend/src/server/api/endpoints/i/read-announcement.ts @@ -47,19 +47,21 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { ) { super(meta, paramDef, async (ps, me) => { // Check if announcement exists - const announcement = await this.announcementsRepository.findOneBy({ id: ps.announcementId }); + const announcementExist = await this.announcementsRepository.exist({ where: { id: ps.announcementId } }); - if (announcement == null) { + if (!announcementExist) { throw new ApiError(meta.errors.noSuchAnnouncement); } // Check if already read - const read = await this.announcementReadsRepository.findOneBy({ - announcementId: ps.announcementId, - userId: me.id, + const alreadyRead = await this.announcementReadsRepository.exist({ + where: { + announcementId: ps.announcementId, + userId: me.id, + }, }); - if (read != null) { + if (alreadyRead) { return; } |