summaryrefslogtreecommitdiff
path: root/packages/backend/src/server/SkRateLimiterService.ts
diff options
context:
space:
mode:
authordakkar <dakkar@thenautilus.net>2025-07-03 12:07:43 +0100
committerdakkar <dakkar@thenautilus.net>2025-07-03 14:16:20 +0100
commitc927c3056767e955e57a6d5f411591688f7de239 (patch)
treee3b96170cbe31da1d8931a61ed8d19914019adaf /packages/backend/src/server/SkRateLimiterService.ts
parentmerge: prepare release 2025.4.3 (!1125) (diff)
downloadsharkey-c927c3056767e955e57a6d5f411591688f7de239.tar.gz
sharkey-c927c3056767e955e57a6d5f411591688f7de239.tar.bz2
sharkey-c927c3056767e955e57a6d5f411591688f7de239.zip
mark grouped notifs by oldest id - sort-of fix 1139
Misskey's code does the same, but our groups behave differently enough that this may be not the best choice for example, let's say we have: - notifications 1-5 for reaction to note A - notifications 6-8 for reaction to note B - notifications 9-12 for reaction to note A - notification 13-19 for non-groupable events - notification 20 for reaction to note A and that events happened one every minute (so the last notification is from 20 minutes ago) client requests the most recent 10 notifications; we fetch notifications 1-10, and reply: - grouped id 6 for reactions 6-8 to note B - grouped id 10 for reactions 1-5, 9-10 to note A then the client requests 10 more notifications, untilId=10; we fetch notifications 11-20, and reply: - non-grouped notifications 13-19 - grouped id 20 for reactions 11,12,20 to note A because we sort by id, and also the `createdAt` marks the _newest_ event in each group, the client will then show: 6 reactions to note B, 6 minutes ago 4 reactions to note A, 1 minute ago notifications 13-19, 13 minutes to 19 minutes ago 3 reactions to note A, 11 minutes ago I don't know how to make this work better ☹
Diffstat (limited to 'packages/backend/src/server/SkRateLimiterService.ts')
0 files changed, 0 insertions, 0 deletions