diff options
| author | dakkar <dakkar@thenautilus.net> | 2025-04-21 14:44:19 +0100 |
|---|---|---|
| committer | dakkar <dakkar@thenautilus.net> | 2025-04-21 16:44:13 +0100 |
| commit | 58c0ac6c8986194d735071f17c008850c28b2064 (patch) | |
| tree | 094ca3984768d899fc30a907fe1e7cac0ac0a927 /packages/backend/src/core/NoteReadService.ts | |
| parent | merge: Verify links in remote accounts. (!964) (diff) | |
| download | sharkey-58c0ac6c8986194d735071f17c008850c28b2064.tar.gz sharkey-58c0ac6c8986194d735071f17c008850c28b2064.tar.bz2 sharkey-58c0ac6c8986194d735071f17c008850c28b2064.zip | |
check signatures with and without query - fix #1036
@Oneric explained:
> Spec says query params must be included in the signature; Mastodon
> being Mastodon used to always exclude it though and for
> compatibility everyone followed this. At some point GtS decided to
> follow spec instead which caused interop issues, but succeeded in
> getting Mastodon (and others like *oma) to accept incoming requests
> with (and also still without) query params though outgoing requests
> remaing query-param-free. Some still only accept query-param-less
> requests though and GtS uses a retry mechanism to resend any request
> failing with 401 with an query-parama-less signature once. (Also
> see:
> https://docs.gotosocial.org/en/latest/federation/http_signatures/ )
>
> So for incoming requests both versions need to be checked. For
> outgoing requests, unless you want to jump through retry hoops like
> GtS, omitting query-params is the safer bet for now (presumably this
> will only change if Mastodon ever decides to send out requests
> signed with query params)
Diffstat (limited to 'packages/backend/src/core/NoteReadService.ts')
0 files changed, 0 insertions, 0 deletions