diff options
| author | dakkar <dakkar@thenautilus.net> | 2025-03-30 09:20:54 +0000 |
|---|---|---|
| committer | dakkar <dakkar@thenautilus.net> | 2025-03-30 09:20:54 +0000 |
| commit | 3a6bba33068395b05b51f21e5c0525376519827e (patch) | |
| tree | bcd53e32f50fd3e35bc026684dbe540545a88e44 /packages/backend/src/core/NoteCreateService.ts | |
| parent | merge: More Mastodon API fixes (resolves #405, #471, and #984) (!954) (diff) | |
| parent | do not make a DM visible if user is mentioned but not a recipient (diff) | |
| download | sharkey-3a6bba33068395b05b51f21e5c0525376519827e.tar.gz sharkey-3a6bba33068395b05b51f21e5c0525376519827e.tar.bz2 sharkey-3a6bba33068395b05b51f21e5c0525376519827e.zip | |
merge: Remove visibility of DMs for non-recipient users (!912)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/912
Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Marie <github@yuugi.dev>
Diffstat (limited to 'packages/backend/src/core/NoteCreateService.ts')
| -rw-r--r-- | packages/backend/src/core/NoteCreateService.ts | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/packages/backend/src/core/NoteCreateService.ts b/packages/backend/src/core/NoteCreateService.ts index df31cb4247..b73091106c 100644 --- a/packages/backend/src/core/NoteCreateService.ts +++ b/packages/backend/src/core/NoteCreateService.ts @@ -866,7 +866,8 @@ export class NoteCreateService implements OnApplicationShutdown { @bindThis private async createMentionedEvents(mentionedUsers: MinimumUser[], note: MiNote, nm: NotificationManager) { - for (const u of mentionedUsers.filter(u => this.userEntityService.isLocalUser(u))) { + // Only create mention events for local users, and users for whom the note is visible + for (const u of mentionedUsers.filter(u => (note.visibility !== 'specified' || note.visibleUserIds.some(x => x === u.id)) && this.userEntityService.isLocalUser(u))) { const isThreadMuted = await this.noteThreadMutingsRepository.exists({ where: { userId: u.id, |