diff options
| author | dakkar <dakkar@thenautilus.net> | 2024-08-06 17:51:51 +0100 |
|---|---|---|
| committer | dakkar <dakkar@thenautilus.net> | 2024-08-06 17:51:51 +0100 |
| commit | 94dceb9e15474f85d94b7ea89a5e2197d4f9b6fc (patch) | |
| tree | 6bb6da6dea6e802a5c5106a90564e11b01a31ddd /packages/backend/src/core/MfmService.ts | |
| parent | appease the linter (diff) | |
| parent | merge: Remove infinite caches to prevent memory leak (!587) (diff) | |
| download | sharkey-94dceb9e15474f85d94b7ea89a5e2197d4f9b6fc.tar.gz sharkey-94dceb9e15474f85d94b7ea89a5e2197d4f9b6fc.tar.bz2 sharkey-94dceb9e15474f85d94b7ea89a5e2197d4f9b6fc.zip | |
Merge branch 'develop' into feature/misskey-2024.07
Diffstat (limited to 'packages/backend/src/core/MfmService.ts')
| -rw-r--r-- | packages/backend/src/core/MfmService.ts | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/packages/backend/src/core/MfmService.ts b/packages/backend/src/core/MfmService.ts index 5619ea4d7b..048910cb52 100644 --- a/packages/backend/src/core/MfmService.ts +++ b/packages/backend/src/core/MfmService.ts @@ -6,7 +6,7 @@ import { URL } from 'node:url'; import { Inject, Injectable } from '@nestjs/common'; import * as parse5 from 'parse5'; -import { Window, XMLSerializer } from 'happy-dom'; +import { Window, DocumentFragment, XMLSerializer } from 'happy-dom'; import { DI } from '@/di-symbols.js'; import type { Config } from '@/config.js'; import { intersperse } from '@/misc/prelude/array.js'; @@ -478,6 +478,8 @@ export class MfmService { const doc = window.document; + const body = doc.createElement('p'); + async function appendChildren(children: mfm.MfmNode[], targetElement: any): Promise<void> { if (children) { for (const child of await Promise.all(children.map(async (x) => await (handlers as any)[x.type](x)))) targetElement.appendChild(child); @@ -656,7 +658,7 @@ export class MfmService { }, }; - await appendChildren(nodes, doc.body); + await appendChildren(nodes, body); if (quoteUri !== null) { const a = doc.createElement('a'); @@ -670,9 +672,15 @@ export class MfmService { quote.innerHTML += 'RE: '; quote.appendChild(a); - doc.body.appendChild(quote); + body.appendChild(quote); + } + + let result = new XMLSerializer().serializeToString(body); + + if (inline) { + result = result.replace(/^<p>/,'').replace(/<\/p>$/,''); } - return inline ? doc.body.innerHTML : `<p>${doc.body.innerHTML}</p>`; + return result; } } |