diff options
| author | syuilo <Syuilotan@yahoo.co.jp> | 2022-02-06 21:58:14 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-06 21:58:14 +0900 |
| commit | b590f352e915d6d7184e2a3d9cf24b0076e33aa3 (patch) | |
| tree | f5d4ac0f4f67793a51023e142885c4bea4d4c892 /CONTRIBUTING.md | |
| parent | Update CONTRIBUTING.md (diff) | |
| download | sharkey-b590f352e915d6d7184e2a3d9cf24b0076e33aa3.tar.gz sharkey-b590f352e915d6d7184e2a3d9cf24b0076e33aa3.tar.bz2 sharkey-b590f352e915d6d7184e2a3d9cf24b0076e33aa3.zip | |
Update CONTRIBUTING.md
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ffd84fc851..d4b9c8ea6a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -42,6 +42,21 @@ Thank you for your PR! Before creating a PR, please check the following: Thanks for your cooperation 🤗 +## Reviewers guide +### Review perspective +- Scope + - Are the goals of the PR clear? + - Is the granularity of the PR appropriate? +- Security + - Does merging this PR create a vulnerability? +- Performance + - Will merging this PR cause unexpected performance degradation? + - Is there a more efficient way? +- Testing + - Does the test ensure the expected behavior? + - Are there any omissions or gaps? + - Does it check for anomalies? + ## Localization (l10n) Misskey uses [Crowdin](https://crowdin.com/project/misskey) for localization management. You can improve our translations with your Crowdin account. |