diff options
| author | dakkar <dakkar@thenautilus.net> | 2024-11-08 16:28:37 +0000 |
|---|---|---|
| committer | dakkar <dakkar@thenautilus.net> | 2024-11-08 16:28:37 +0000 |
| commit | b4e8e78172af9d07793fcea0261b0acb203a07e5 (patch) | |
| tree | 2713b3f8b9d9e59fc5dfc99d360d7e25fd918f62 /CONTRIBUTING.md | |
| parent | regenerate misskey-js (diff) | |
| download | sharkey-b4e8e78172af9d07793fcea0261b0acb203a07e5.tar.gz sharkey-b4e8e78172af9d07793fcea0261b0acb203a07e5.tar.bz2 sharkey-b4e8e78172af9d07793fcea0261b0acb203a07e5.zip | |
replace new icons
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3a80d55900..c0f991c215 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -647,8 +647,9 @@ seems to do a decent job) against Misskey (`git diff misskey/develop`) * re-generate `misskey-js` (`pnpm build-misskey-js-with-types`) and commit * build the frontend: `rm -rf built/; NODE_ENV=development pnpm - --filter=frontend --filter=frontend-embed build` (the `development` - tells it to keep some of the original filenames in the built files) + --filter=frontend --filter=frontend-embed --filter=frontend-shared + build` (the `development` tells it to keep some of the original + filenames in the built files) * make sure there aren't any new `ti-*` classes (Tabler Icons), and replace them with appropriate `ph-*` ones (Phosphor Icons): `grep -rP '["'\'']ti[ -](?!fw)' -- built/` should show you what to change. @@ -656,7 +657,8 @@ seems to do a decent job) alone after every change, re-build the frontend and check again, until - there are no more `ti-*` classes in the built files + there are no more `ti-*` classes in the built files (you can ignore + the source maps) commit! * double-check the new migration, that they won't conflict with our db |