diff options
| author | dakkar <dakkar@thenautilus.net> | 2025-05-30 17:44:35 +0100 |
|---|---|---|
| committer | dakkar <dakkar@thenautilus.net> | 2025-05-30 17:44:35 +0100 |
| commit | 5c680d65c78ba15c214bb3aae772b80d353b80a7 (patch) | |
| tree | 6c3ad33db15e3442d76d1bda4d4a172b64794471 /CONTRIBUTING.md | |
| parent | apply more styles to our icons - fixes #1081 (diff) | |
| download | sharkey-5c680d65c78ba15c214bb3aae772b80d353b80a7.tar.gz sharkey-5c680d65c78ba15c214bb3aae772b80d353b80a7.tar.bz2 sharkey-5c680d65c78ba15c214bb3aae772b80d353b80a7.zip | |
replace more icons
in a few places icon classes are constructed from string constants,
and those not always include the `ti` prefix
also updated the `grep` in `CONTRIBUTING.md` to catch those kind of
constants.
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c8a58fadab..ef08d5275f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -690,7 +690,7 @@ seems to do a decent job) * re-generate locales (`pnpm run build-assets`) and commit * build the frontend: `rm -rf built/; NODE_ENV=development pnpm --filter=frontend --filter=frontend-embed --filter=frontend-shared build` (the `development` tells it to keep some of the original filenames in the built files) * make sure there aren't any new `ti-*` classes (Tabler Icons), and replace them with appropriate `ph-*` ones (Phosphor Icons) in [`vite.replaceicons.ts`](packages/frontend/vite.replaceIcons.ts). - * This command should show you want to change: `grep -ohrP '(?<=["'\'']ti )(ti-(?!fw)[\w\-]+)' --exclude \*.map -- built/ | sort -u`. + * This command should show you want to change: `grep -ohrP '(?<=["'\''](ti )?)(ti-(?!fw)[\w\-]+)' --exclude \*.map -- built/ | sort -u`. * NOTE: `ti-fw` is a special class that's defined by Misskey, leave it alone. * After every change, re-build the frontend and check again, until there are no more `ti-*` classes in the built files. * Commit! |