summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMeiMei <30769358+mei23@users.noreply.github.com>2021-08-18 22:04:04 +0900
committerGitHub <noreply@github.com>2021-08-18 22:04:04 +0900
commit881b914c6a7bdf73ed16194e71aa779b27de074e (patch)
tree9915f6423c771ed4120bd7d5741780221b7a463c
parentMerge branch 'develop' of https://github.com/misskey-dev/misskey into develop (diff)
downloadsharkey-881b914c6a7bdf73ed16194e71aa779b27de074e.tar.gz
sharkey-881b914c6a7bdf73ed16194e71aa779b27de074e.tar.bz2
sharkey-881b914c6a7bdf73ed16194e71aa779b27de074e.zip
チャンネルを作成しているとアカウントを削除できないのを修正 (#7653)
* チャンネルを作成しているとアカウントを削除できないのを修正 * CHANGELOG * nullable
-rw-r--r--CHANGELOG.md7
-rw-r--r--migration/1629288472000-fix-channel-userId.ts14
-rw-r--r--src/models/entities/channel.ts3
-rw-r--r--src/models/repositories/channel.ts2
4 files changed, 24 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index f6d782c519..2ce3065a10 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,13 @@
-->
+## 12.x.x (unreleased)
+
+### Improvements
+
+### Bugfixes
+- チャンネルを作成しているとアカウントを削除できないのを修正
+
## 12.88.0 (2021/08/17)
### Features
diff --git a/migration/1629288472000-fix-channel-userId.ts b/migration/1629288472000-fix-channel-userId.ts
new file mode 100644
index 0000000000..cd8f81bb01
--- /dev/null
+++ b/migration/1629288472000-fix-channel-userId.ts
@@ -0,0 +1,14 @@
+import {MigrationInterface, QueryRunner} from "typeorm";
+
+export class fixChannelUserId1629288472000 implements MigrationInterface {
+ name = 'fixChannelUserId1629288472000'
+
+ public async up(queryRunner: QueryRunner): Promise<void> {
+ await queryRunner.query(`ALTER TABLE "channel" ALTER COLUMN "userId" DROP NOT NULL;`);
+ }
+
+ public async down(queryRunner: QueryRunner): Promise<void> {
+ await queryRunner.query(`ALTER TABLE "channel" ALTER COLUMN "userId" SET NOT NULL;`);
+ }
+
+}
diff --git a/src/models/entities/channel.ts b/src/models/entities/channel.ts
index 1868f75143..f2d713612d 100644
--- a/src/models/entities/channel.ts
+++ b/src/models/entities/channel.ts
@@ -23,9 +23,10 @@ export class Channel {
@Index()
@Column({
...id(),
+ nullable: true,
comment: 'The owner ID.'
})
- public userId: User['id'];
+ public userId: User['id'] | null;
@ManyToOne(type => User, {
onDelete: 'SET NULL'
diff --git a/src/models/repositories/channel.ts b/src/models/repositories/channel.ts
index 3a6bd4c923..007b110015 100644
--- a/src/models/repositories/channel.ts
+++ b/src/models/repositories/channel.ts
@@ -90,7 +90,7 @@ export const packedChannelSchema = {
},
userId: {
type: 'string' as const,
- nullable: false as const, optional: false as const,
+ nullable: true as const, optional: false as const,
format: 'id',
},
},