diff options
| author | Marie <github@yuugi.dev> | 2024-11-28 03:31:40 +0000 |
|---|---|---|
| committer | Marie <github@yuugi.dev> | 2024-11-28 03:31:40 +0000 |
| commit | 7aba846446e7e44ff5cf4fdb92f36ea367ddc763 (patch) | |
| tree | 3bcd36ec3280a97a2f6a73bc3898157002186543 | |
| parent | merge: only "publish to followers" when things really change - fixes #733 (!781) (diff) | |
| parent | simpler check for "property present" (diff) | |
| download | sharkey-7aba846446e7e44ff5cf4fdb92f36ea367ddc763.tar.gz sharkey-7aba846446e7e44ff5cf4fdb92f36ea367ddc763.tar.bz2 sharkey-7aba846446e7e44ff5cf4fdb92f36ea367ddc763.zip | |
merge: silence linter (!785)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/785
Approved-by: Marie <github@yuugi.dev>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
| -rw-r--r-- | packages/backend/src/server/api/endpoints/i/update.ts | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/packages/backend/src/server/api/endpoints/i/update.ts b/packages/backend/src/server/api/endpoints/i/update.ts index f0e8dfc832..8e61b8f784 100644 --- a/packages/backend/src/server/api/endpoints/i/update.ts +++ b/packages/backend/src/server/api/endpoints/i/update.ts @@ -588,12 +588,12 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- // `ApRendererService.renderPerson` private userNeedsPublishing(oldUser: MiLocalUser, newUser: Partial<MiUser>): boolean { for (const field of ['avatarId', 'bannerId', 'backgroundId', 'isBot', 'username', 'name', 'isLocked', 'isExplorable', 'isCat', 'noindex', 'speakAsCat', 'movedToUri', 'alsoKnownAs'] as (keyof MiUser)[]) { - if (newUser.hasOwnProperty(field) && oldUser[field] !== newUser[field]) { + if ((field in newUser) && oldUser[field] !== newUser[field]) { return true; } } for (const arrayField of ['emojis', 'tags'] as (keyof MiUser)[]) { - if (newUser.hasOwnProperty(arrayField) !== oldUser.hasOwnProperty(arrayField)) { + if ((arrayField in newUser) !== (arrayField in oldUser)) { return true; } @@ -611,12 +611,12 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- private profileNeedsPublishing(oldProfile: MiUserProfile, newProfile: Partial<MiUserProfile>): boolean { for (const field of ['description', 'followedMessage', 'birthday', 'location', 'listenbrainz'] as (keyof MiUserProfile)[]) { - if (newProfile.hasOwnProperty(field) && oldProfile[field] !== newProfile[field]) { + if ((field in newProfile) && oldProfile[field] !== newProfile[field]) { return true; } } for (const arrayField of ['fields'] as (keyof MiUserProfile)[]) { - if (newProfile.hasOwnProperty(arrayField) !== oldProfile.hasOwnProperty(arrayField)) { + if ((arrayField in newProfile) !== (arrayField in oldProfile)) { return true; } |