summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHazelnoot <acomputerdog@gmail.com>2024-12-11 14:07:25 -0500
committerHazelnoot <acomputerdog@gmail.com>2024-12-11 14:07:25 -0500
commit755ff8783b9b4c1b4e5949fa417e0c85a8bc0e29 (patch)
tree9100d805f65fbf729eb44b8e4c5d647f70c63e22
parentfix SkRateLimiterService tests (diff)
downloadsharkey-755ff8783b9b4c1b4e5949fa417e0c85a8bc0e29.tar.gz
sharkey-755ff8783b9b4c1b4e5949fa417e0c85a8bc0e29.tar.bz2
sharkey-755ff8783b9b4c1b4e5949fa417e0c85a8bc0e29.zip
clarify naming of legacy rate limit methods
-rw-r--r--packages/backend/src/server/api/SkRateLimiterService.ts8
1 files changed, 4 insertions, 4 deletions
diff --git a/packages/backend/src/server/api/SkRateLimiterService.ts b/packages/backend/src/server/api/SkRateLimiterService.ts
index d349e192e1..38c97b63df 100644
--- a/packages/backend/src/server/api/SkRateLimiterService.ts
+++ b/packages/backend/src/server/api/SkRateLimiterService.ts
@@ -55,15 +55,15 @@ export class SkRateLimiterService {
private async limitLegacy(limit: Keyed<LegacyRateLimit>, actor: string, factor: number): Promise<LimitInfo> {
if (hasMaxLimit(limit)) {
- return await this.limitMaxLegacy(limit, actor, factor);
+ return await this.limitLegacyMinMax(limit, actor, factor);
} else if (hasMinLimit(limit)) {
- return await this.limitMinLegacy(limit, actor, factor);
+ return await this.limitLegacyMinOnly(limit, actor, factor);
} else {
return disabledLimitInfo;
}
}
- private async limitMaxLegacy(limit: Keyed<MaxLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> {
+ private async limitLegacyMinMax(limit: Keyed<MaxLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> {
if (limit.duration === 0) return disabledLimitInfo;
if (limit.duration < 0) throw new Error(`Invalid rate limit ${limit.key}: duration is negative (${limit.duration})`);
if (limit.max < 1) throw new Error(`Invalid rate limit ${limit.key}: max is less than 1 (${limit.max})`);
@@ -87,7 +87,7 @@ export class SkRateLimiterService {
return await this.limitBucket(bucketLimit, actor, factor);
}
- private async limitMinLegacy(limit: Keyed<MinLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> {
+ private async limitLegacyMinOnly(limit: Keyed<MinLegacyLimit>, actor: string, factor: number): Promise<LimitInfo> {
if (limit.minInterval === 0) return disabledLimitInfo;
if (limit.minInterval < 0) throw new Error(`Invalid rate limit ${limit.key}: minInterval is negative (${limit.minInterval})`);