diff options
| author | Kagami Sascha Rosylight <saschanaz@outlook.com> | 2023-03-01 07:32:53 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-01 15:32:53 +0900 |
| commit | 44058f8b855ddffb1451241f0c28fb0cf3d9845c (patch) | |
| tree | e7a4a919216a11392118eb83e9db204ef70b2da3 | |
| parent | fix(frontend): read KeyboardEvent.key instead of which/code (#10083) (diff) | |
| download | sharkey-44058f8b855ddffb1451241f0c28fb0cf3d9845c.tar.gz sharkey-44058f8b855ddffb1451241f0c28fb0cf3d9845c.tar.bz2 sharkey-44058f8b855ddffb1451241f0c28fb0cf3d9845c.zip | |
enhance(e2e): more resilient version of `visit('/')` (#10128)
| -rw-r--r-- | cypress/e2e/basic.cy.js | 14 | ||||
| -rw-r--r-- | cypress/support/commands.js | 7 |
2 files changed, 13 insertions, 8 deletions
diff --git a/cypress/e2e/basic.cy.js b/cypress/e2e/basic.cy.js index fc3e6f35bc..b1b856119c 100644 --- a/cypress/e2e/basic.cy.js +++ b/cypress/e2e/basic.cy.js @@ -10,11 +10,11 @@ describe('Before setup instance', () => { }); it('successfully loads', () => { - cy.visit('/'); + cy.visitHome(); }); it('setup instance', () => { - cy.visit('/'); + cy.visitHome(); cy.intercept('POST', '/api/admin/accounts/create').as('signup'); @@ -43,11 +43,11 @@ describe('After setup instance', () => { }); it('successfully loads', () => { - cy.visit('/'); + cy.visitHome(); }); it('signup', () => { - cy.visit('/'); + cy.visitHome(); cy.intercept('POST', '/api/signup').as('signup'); @@ -79,11 +79,11 @@ describe('After user signup', () => { }); it('successfully loads', () => { - cy.visit('/'); + cy.visitHome(); }); it('signin', () => { - cy.visit('/'); + cy.visitHome(); cy.intercept('POST', '/api/signin').as('signin'); @@ -101,7 +101,7 @@ describe('After user signup', () => { userId: this.alice.id, }); - cy.visit('/'); + cy.visitHome(); cy.get('[data-cy-signin]').click(); cy.get('[data-cy-signin-username] input').type('alice'); diff --git a/cypress/support/commands.js b/cypress/support/commands.js index 04a6d98b01..91a4d7abe6 100644 --- a/cypress/support/commands.js +++ b/cypress/support/commands.js @@ -24,6 +24,11 @@ // -- This will overwrite an existing command -- // Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... }) +Cypress.Commands.add('visitHome', () => { + cy.visit('/'); + cy.get('button', { timeout: 30000 }).should('be.visible'); +}) + Cypress.Commands.add('resetState', () => { cy.window(win => { win.indexedDB.deleteDatabase('keyval-store'); @@ -43,7 +48,7 @@ Cypress.Commands.add('registerUser', (username, password, isAdmin = false) => { }); Cypress.Commands.add('login', (username, password) => { - cy.visit('/'); + cy.visitHome(); cy.intercept('POST', '/api/signin').as('signin'); |