summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAcid Chicken (硫酸鶏) <root@acid-chicken.com>2020-05-05 10:22:49 +0900
committerGitHub <noreply@github.com>2020-05-05 10:22:49 +0900
commit4cccdb8a98ffd69584c7139545ecd17bfb3b7a3e (patch)
tree8bad0d079776b8fd3e20cfe65b44f205a0763287 /src
parentchore: Update dependencies :rocket: (diff)
parentUpdate hcaptcha.d.ts (diff)
downloadmisskey-4cccdb8a98ffd69584c7139545ecd17bfb3b7a3e.tar.gz
misskey-4cccdb8a98ffd69584c7139545ecd17bfb3b7a3e.tar.bz2
misskey-4cccdb8a98ffd69584c7139545ecd17bfb3b7a3e.zip
Merge pull request #6303 from syuilo/features/hcaptcha
Add support for hCaptcha
Diffstat (limited to 'src')
-rw-r--r--src/@types/hcaptcha.d.ts11
-rw-r--r--src/client/components/captcha.vue119
-rw-r--r--src/client/components/signup-dialog.vue2
-rw-r--r--src/client/components/signup.vue44
-rw-r--r--src/client/components/url-preview.vue2
-rw-r--r--src/client/pages/instance/settings.vue82
-rw-r--r--src/models/entities/meta.ts17
-rw-r--r--src/server/api/endpoints/admin/update-meta.ts33
-rw-r--r--src/server/api/endpoints/meta.ts4
-rw-r--r--src/server/api/private/signup.ts30
-rw-r--r--src/server/nodeinfo.ts1
-rw-r--r--src/server/web/views/info.pug3
12 files changed, 302 insertions, 46 deletions
diff --git a/src/@types/hcaptcha.d.ts b/src/@types/hcaptcha.d.ts
new file mode 100644
index 0000000000..afed587560
--- /dev/null
+++ b/src/@types/hcaptcha.d.ts
@@ -0,0 +1,11 @@
+declare module 'hcaptcha' {
+ interface IVerifyResponse {
+ success: boolean;
+ challenge_ts: string;
+ hostname: string;
+ credit?: boolean;
+ 'error-codes'?: unknown[];
+ }
+
+ export function verify(secret: string, token: string): Promise<IVerifyResponse>;
+}
diff --git a/src/client/components/captcha.vue b/src/client/components/captcha.vue
new file mode 100644
index 0000000000..6b1ee6f0b2
--- /dev/null
+++ b/src/client/components/captcha.vue
@@ -0,0 +1,119 @@
+<template>
+<div>
+ <span v-if="!available">{{ $t('waiting') }}<mk-ellipsis/></span>
+ <div ref="captcha"></div>
+</div>
+</template>
+
+<script lang="ts">
+import Vue from 'vue';
+import i18n from '../i18n';
+
+type Captcha = {
+ render(container: string | Node, options: {
+ readonly [_ in 'sitekey' | 'theme' | 'type' | 'size' | 'tabindex' | 'callback' | 'expired' | 'expired-callback' | 'error-callback' | 'endpoint']?: unknown;
+ }): string;
+ remove(id: string): void;
+ execute(id: string): void;
+ reset(id: string): void;
+ getResponse(id: string): string;
+};
+
+type CaptchaProvider = 'hcaptcha' | 'grecaptcha';
+
+type CaptchaContainer = {
+ readonly [_ in CaptchaProvider]?: Captcha;
+};
+
+declare global {
+ interface Window extends CaptchaContainer {
+ }
+}
+
+export default Vue.extend({
+ i18n,
+ props: {
+ provider: {
+ type: String,
+ required: true,
+ },
+ sitekey: {
+ type: String,
+ required: true,
+ },
+ value: {
+ type: String,
+ },
+ },
+
+ data() {
+ return {
+ available: false,
+ };
+ },
+
+ computed: {
+ loaded() {
+ return !!window[this.provider as CaptchaProvider];
+ },
+ src() {
+ const endpoint = ({
+ hcaptcha: 'https://hcaptcha.com/1',
+ grecaptcha: 'https://www.google.com/recaptcha',
+ } as Record<PropertyKey, unknown>)[this.provider];
+
+ return `${typeof endpoint == 'string' ? endpoint : 'about:invalid'}/api.js?render=explicit`;
+ },
+ captcha() {
+ return window[this.provider as CaptchaProvider] || {} as unknown as Captcha;
+ },
+ },
+
+ created() {
+ if (this.loaded) {
+ this.available = true;
+ } else {
+ (document.getElementById(this.provider) || document.head.appendChild(Object.assign(document.createElement('script'), {
+ async: true,
+ id: this.provider,
+ src: this.src,
+ })))
+ .addEventListener('load', () => this.available = true);
+ }
+ },
+
+ mounted() {
+ if (this.available) {
+ this.requestRender();
+ } else {
+ this.$watch('available', this.requestRender);
+ }
+ },
+
+ beforeDestroy() {
+ this.reset();
+ },
+
+ methods: {
+ reset() {
+ this.captcha?.reset();
+ },
+ requestRender() {
+ if (this.captcha.render && this.$refs.captcha instanceof Element) {
+ this.captcha.render(this.$refs.captcha, {
+ sitekey: this.sitekey,
+ theme: this.$store.state.device.darkMode ? 'dark' : 'light',
+ callback: this.callback,
+ 'expired-callback': this.callback,
+ 'error-callback': this.callback,
+ });
+ } else {
+ setTimeout(this.requestRender.bind(this), 1);
+ }
+ },
+ callback(response?: string) {
+ this.$emit('input', typeof response == 'string' ? response : null);
+ },
+ },
+});
+</script>
diff --git a/src/client/components/signup-dialog.vue b/src/client/components/signup-dialog.vue
index 10cdf3a567..4db79af512 100644
--- a/src/client/components/signup-dialog.vue
+++ b/src/client/components/signup-dialog.vue
@@ -1,5 +1,5 @@
<template>
-<x-window ref="window" @closed="() => { $emit('closed'); destroyDom(); }">
+<x-window ref="window" :width="366" :height="506" @closed="() => { $emit('closed'); destroyDom(); }">
<template #header>{{ $t('signup') }}</template>
<x-signup :auto-set="autoSet" @signup="onSignup"/>
</x-window>
diff --git a/src/client/components/signup.vue b/src/client/components/signup.vue
index 9f3ae8db28..6452afc886 100644
--- a/src/client/components/signup.vue
+++ b/src/client/components/signup.vue
@@ -41,8 +41,9 @@
<a :href="meta.tosUrl" class="_link" target="_blank">{{ $t('tos') }}</a>
</i18n>
</mk-switch>
- <div v-if="meta.enableRecaptcha" class="g-recaptcha" :data-sitekey="meta.recaptchaSiteKey" style="margin: 16px 0;"></div>
- <mk-button type="submit" :disabled=" submitting || !(meta.tosUrl ? ToSAgreement : true) || passwordRetypeState == 'not-match'" primary>{{ $t('start') }}</mk-button>
+ <captcha v-if="meta.enableHcaptcha" class="captcha" provider="hcaptcha" ref="hcaptcha" v-model="hCaptchaResponse" :sitekey="meta.hcaptchaSiteKey"/>
+ <captcha v-if="meta.enableRecaptcha" class="captcha" provider="grecaptcha" ref="recaptcha" v-model="reCaptchaResponse" :sitekey="meta.recaptchaSiteKey"/>
+ <mk-button type="submit" :disabled="shouldDisableSubmitting" primary>{{ $t('start') }}</mk-button>
</template>
</form>
</template>
@@ -65,6 +66,7 @@ export default Vue.extend({
MkButton,
MkInput,
MkSwitch,
+ captcha: () => import('./captcha.vue').then(x => x.default),
},
data() {
@@ -80,6 +82,8 @@ export default Vue.extend({
passwordRetypeState: null,
submitting: false,
ToSAgreement: false,
+ hCaptchaResponse: null,
+ reCaptchaResponse: null,
faLock, faExclamationTriangle, faSpinner, faCheck, faKey
}
},
@@ -96,7 +100,15 @@ export default Vue.extend({
meta() {
return this.$store.state.instance.meta;
},
-
+
+ shouldDisableSubmitting(): boolean {
+ return this.submitting ||
+ this.meta.tosUrl && !this.ToSAgreement ||
+ this.meta.enableHcaptcha && !this.hCaptchaResponse ||
+ this.meta.enableRecaptcha && !this.reCaptchaResponse ||
+ this.passwordRetypeState == 'not-match';
+ },
+
shouldShowProfileUrl(): boolean {
return (this.username != '' &&
this.usernameState != 'invalid-format' &&
@@ -114,13 +126,6 @@ export default Vue.extend({
}
},
- mounted() {
- const head = document.getElementsByTagName('head')[0];
- const script = document.createElement('script');
- script.setAttribute('src', 'https://www.google.com/recaptcha/api.js');
- head.appendChild(script);
- },
-
methods: {
onChangeUsername() {
if (this.username == '') {
@@ -177,7 +182,8 @@ export default Vue.extend({
username: this.username,
password: this.password,
invitationCode: this.invitationCode,
- 'g-recaptcha-response': this.meta.enableRecaptcha ? (window as any).grecaptcha.getResponse() : null
+ 'hcaptcha-response': this.hCaptchaResponse,
+ 'g-recaptcha-response': this.meta.reCaptchaResponse,
}).then(() => {
this.$root.api('signin', {
username: this.username,
@@ -187,17 +193,25 @@ export default Vue.extend({
});
}).catch(() => {
this.submitting = false;
+ this.$refs.hcaptcha?.reset?.();
+ this.$refs.recaptcha?.reset?.();
this.$root.dialog({
type: 'error',
text: this.$t('error')
});
-
- if (this.meta.enableRecaptcha) {
- (window as any).grecaptcha.reset();
- }
});
}
}
});
</script>
+
+<style lang="scss" scoped>
+.mk-signup {
+ padding: 32px 0 0;
+
+ .captcha {
+ margin: 16px 0;
+ }
+}
+</style>
diff --git a/src/client/components/url-preview.vue b/src/client/components/url-preview.vue
index 94d07cbaed..c2dd0038be 100644
--- a/src/client/components/url-preview.vue
+++ b/src/client/components/url-preview.vue
@@ -4,7 +4,7 @@
<iframe :src="player.url + (player.url.match(/\?/) ? '&autoplay=1&auto_play=1' : '?autoplay=1&auto_play=1')" :width="player.width || '100%'" :heigth="player.height || 250" frameborder="0" allow="autoplay; encrypted-media" allowfullscreen />
</div>
<div v-else-if="tweetUrl && detail" class="twitter">
- <blockquote ref="tweet" class="twitter-tweet" :data-theme="$store.state.device.darkmode ? 'dark' : null">
+ <blockquote ref="tweet" class="twitter-tweet" :data-theme="$store.state.device.darkMode ? 'dark' : null">
<a :href="url"></a>
</blockquote>
</div>
diff --git a/src/client/pages/instance/settings.vue b/src/client/pages/instance/settings.vue
index f7db4aa10b..afd6d4cc6d 100644
--- a/src/client/pages/instance/settings.vue
+++ b/src/client/pages/instance/settings.vue
@@ -39,9 +39,27 @@
</section>
<section class="_card">
+ <div class="_title"><fa :icon="faShieldAlt"/> {{ $t('hcaptcha') }}</div>
+ <div class="_content">
+ <mk-switch v-model="enableHcaptcha" ref="enableHcaptcha">{{ $t('enableHcaptcha') }}</mk-switch>
+ <template v-if="enableHcaptcha">
+ <mk-input v-model="hcaptchaSiteKey" :disabled="!enableHcaptcha"><template #icon><fa :icon="faKey"/></template>{{ $t('hcaptchaSiteKey') }}</mk-input>
+ <mk-input v-model="hcaptchaSecretKey" :disabled="!enableHcaptcha"><template #icon><fa :icon="faKey"/></template>{{ $t('hcaptchaSecretKey') }}</mk-input>
+ </template>
+ </div>
+ <div class="_content" v-if="enableHcaptcha">
+ <header>{{ $t('preview') }}</header>
+ <captcha v-if="enableHcaptcha" provider="hcaptcha" :sitekey="hcaptchaSiteKey || '10000000-ffff-ffff-ffff-000000000001'"/>
+ </div>
+ <div class="_footer">
+ <mk-button primary @click="save(true)"><fa :icon="faSave"/> {{ $t('save') }}</mk-button>
+ </div>
+ </section>
+
+ <section class="_card">
<div class="_title"><fa :icon="faShieldAlt"/> {{ $t('recaptcha') }}</div>
<div class="_content">
- <mk-switch v-model="enableRecaptcha">{{ $t('enableRecaptcha') }}</mk-switch>
+ <mk-switch v-model="enableRecaptcha" ref="enableRecaptcha">{{ $t('enableRecaptcha') }}</mk-switch>
<template v-if="enableRecaptcha">
<mk-input v-model="recaptchaSiteKey" :disabled="!enableRecaptcha"><template #icon><fa :icon="faKey"/></template>{{ $t('recaptchaSiteKey') }}</mk-input>
<mk-input v-model="recaptchaSecretKey" :disabled="!enableRecaptcha"><template #icon><fa :icon="faKey"/></template>{{ $t('recaptchaSecretKey') }}</mk-input>
@@ -49,7 +67,7 @@
</div>
<div class="_content" v-if="enableRecaptcha && recaptchaSiteKey">
<header>{{ $t('preview') }}</header>
- <div ref="recaptcha" style="margin: 16px 0 0 0;" :key="recaptchaSiteKey"></div>
+ <captcha v-if="enableRecaptcha" provider="grecaptcha" :sitekey="recaptchaSiteKey"/>
</div>
<div class="_footer">
<mk-button primary @click="save(true)"><fa :icon="faSave"/> {{ $t('save') }}</mk-button>
@@ -210,6 +228,7 @@ export default Vue.extend({
MkTextarea,
MkSwitch,
MkInfo,
+ Captcha: () => import('../../components/captcha.vue').then(x => x.default),
},
data() {
@@ -234,6 +253,9 @@ export default Vue.extend({
enableRegistration: false,
enableLocalTimeline: false,
enableGlobalTimeline: false,
+ enableHcaptcha: false,
+ hcaptchaSiteKey: null,
+ hcaptchaSecretKey: null,
enableRecaptcha: false,
recaptchaSiteKey: null,
recaptchaSecretKey: null,
@@ -282,6 +304,9 @@ export default Vue.extend({
this.enableRegistration = !this.meta.disableRegistration;
this.enableLocalTimeline = !this.meta.disableLocalTimeline;
this.enableGlobalTimeline = !this.meta.disableGlobalTimeline;
+ this.enableHcaptcha = this.meta.enableHcaptcha;
+ this.hcaptchaSiteKey = this.meta.hcaptchaSiteKey;
+ this.hcaptchaSecretKey = this.meta.hcaptchaSecretKey;
this.enableRecaptcha = this.meta.enableRecaptcha;
this.recaptchaSiteKey = this.meta.recaptchaSiteKey;
this.recaptchaSecretKey = this.meta.recaptchaSecretKey;
@@ -324,26 +349,38 @@ export default Vue.extend({
},
mounted() {
- const renderRecaptchaPreview = () => {
- if (!(window as any).grecaptcha) return;
- if (!this.$refs.recaptcha) return;
- if (!this.recaptchaSiteKey) return;
- (window as any).grecaptcha.render(this.$refs.recaptcha, {
- sitekey: this.recaptchaSiteKey
- });
- };
- window.onRecaotchaLoad = () => {
- renderRecaptchaPreview();
- };
- const head = document.getElementsByTagName('head')[0];
- const script = document.createElement('script');
- script.setAttribute('src', 'https://www.google.com/recaptcha/api.js?onload=onRecaotchaLoad');
- head.appendChild(script);
- this.$watch('enableRecaptcha', () => {
- renderRecaptchaPreview();
+ this.$refs.enableHcaptcha.$on('change', () => {
+ if (this.enableHcaptcha && this.enableRecaptcha) {
+ this.$root.dialog({
+ type: 'question', // warning だと間違って cancel するかもしれない
+ showCancelButton: true,
+ title: this.$t('settingGuide'),
+ text: this.$t('avoidMultiCaptchaConfirm'),
+ }).then(({ canceled }) => {
+ if (canceled) {
+ return;
+ }
+
+ this.enableRecaptcha = false;
+ });
+ }
});
- this.$watch('recaptchaSiteKey', () => {
- renderRecaptchaPreview();
+
+ this.$refs.enableRecaptcha.$on('change', () => {
+ if (this.enableRecaptcha && this.enableHcaptcha) {
+ this.$root.dialog({
+ type: 'question', // warning だと間違って cancel するかもしれない
+ showCancelButton: true,
+ title: this.$t('settingGuide'),
+ text: this.$t('avoidMultiCaptchaConfirm'),
+ }).then(({ canceled }) => {
+ if (canceled) {
+ return;
+ }
+
+ this.enableHcaptcha = false;
+ });
+ }
});
},
@@ -391,6 +428,9 @@ export default Vue.extend({
disableRegistration: !this.enableRegistration,
disableLocalTimeline: !this.enableLocalTimeline,
disableGlobalTimeline: !this.enableGlobalTimeline,
+ enableHcaptcha: this.enableHcaptcha,
+ hcaptchaSiteKey: this.hcaptchaSiteKey,
+ hcaptchaSecretKey: this.hcaptchaSecretKey,
enableRecaptcha: this.enableRecaptcha,
recaptchaSiteKey: this.recaptchaSiteKey,
recaptchaSecretKey: this.recaptchaSecretKey,
diff --git a/src/models/entities/meta.ts b/src/models/entities/meta.ts
index bb463c52f4..622d28bead 100644
--- a/src/models/entities/meta.ts
+++ b/src/models/entities/meta.ts
@@ -127,6 +127,23 @@ export class Meta {
@Column('boolean', {
default: false,
})
+ public enableHcaptcha: boolean;
+
+ @Column('varchar', {
+ length: 64,
+ nullable: true
+ })
+ public hcaptchaSiteKey: string | null;
+
+ @Column('varchar', {
+ length: 64,
+ nullable: true
+ })
+ public hcaptchaSecretKey: string | null;
+
+ @Column('boolean', {
+ default: false,
+ })
public enableRecaptcha: boolean;
@Column('varchar', {
diff --git a/src/server/api/endpoints/admin/update-meta.ts b/src/server/api/endpoints/admin/update-meta.ts
index 1bc20029ef..dffe7ffe7f 100644
--- a/src/server/api/endpoints/admin/update-meta.ts
+++ b/src/server/api/endpoints/admin/update-meta.ts
@@ -145,6 +145,27 @@ export const meta = {
}
},
+ enableHcaptcha: {
+ validator: $.optional.bool,
+ desc: {
+ 'ja-JP': 'hCaptchaを使用するか否か'
+ }
+ },
+
+ hcaptchaSiteKey: {
+ validator: $.optional.nullable.str,
+ desc: {
+ 'ja-JP': 'hCaptcha site key'
+ }
+ },
+
+ hcaptchaSecretKey: {
+ validator: $.optional.nullable.str,
+ desc: {
+ 'ja-JP': 'hCaptcha secret key'
+ }
+ },
+
enableRecaptcha: {
validator: $.optional.bool,
desc: {
@@ -472,6 +493,18 @@ export default define(meta, async (ps, me) => {
set.proxyRemoteFiles = ps.proxyRemoteFiles;
}
+ if (ps.enableHcaptcha !== undefined) {
+ set.enableHcaptcha = ps.enableHcaptcha;
+ }
+
+ if (ps.hcaptchaSiteKey !== undefined) {
+ set.hcaptchaSiteKey = ps.hcaptchaSiteKey;
+ }
+
+ if (ps.hcaptchaSecretKey !== undefined) {
+ set.hcaptchaSecretKey = ps.hcaptchaSecretKey;
+ }
+
if (ps.enableRecaptcha !== undefined) {
set.enableRecaptcha = ps.enableRecaptcha;
}
diff --git a/src/server/api/endpoints/meta.ts b/src/server/api/endpoints/meta.ts
index 179355489b..eefc370124 100644
--- a/src/server/api/endpoints/meta.ts
+++ b/src/server/api/endpoints/meta.ts
@@ -122,6 +122,8 @@ export default define(meta, async (ps, me) => {
driveCapacityPerRemoteUserMb: instance.remoteDriveCapacityMb,
cacheRemoteFiles: instance.cacheRemoteFiles,
proxyRemoteFiles: instance.proxyRemoteFiles,
+ enableHcaptcha: instance.enableHcaptcha,
+ hcaptchaSiteKey: instance.hcaptchaSiteKey,
enableRecaptcha: instance.enableRecaptcha,
recaptchaSiteKey: instance.recaptchaSiteKey,
swPublickey: instance.swPublicKey,
@@ -149,6 +151,7 @@ export default define(meta, async (ps, me) => {
localTimeLine: !instance.disableLocalTimeline,
globalTimeLine: !instance.disableGlobalTimeline,
elasticsearch: config.elasticsearch ? true : false,
+ hcaptcha: instance.enableHcaptcha,
recaptcha: instance.enableRecaptcha,
objectStorage: instance.useObjectStorage,
twitter: instance.enableTwitterIntegration,
@@ -164,6 +167,7 @@ export default define(meta, async (ps, me) => {
response.pinnedUsers = instance.pinnedUsers;
response.hiddenTags = instance.hiddenTags;
response.blockedHosts = instance.blockedHosts;
+ response.hcaptchaSecretKey = instance.hcaptchaSecretKey;
response.recaptchaSecretKey = instance.recaptchaSecretKey;
response.proxyAccountId = instance.proxyAccountId;
response.twitterConsumerKey = instance.twitterConsumerKey;
diff --git a/src/server/api/private/signup.ts b/src/server/api/private/signup.ts
index 79ee74389c..6dc252ac45 100644
--- a/src/server/api/private/signup.ts
+++ b/src/server/api/private/signup.ts
@@ -1,5 +1,6 @@
import * as Koa from 'koa';
import { fetchMeta } from '../../../misc/fetch-meta';
+import { verify } from 'hcaptcha';
import * as recaptcha from 'recaptcha-promise';
import { Users, RegistrationTickets } from '../../../models';
import { signup } from '../common/signup';
@@ -9,17 +10,30 @@ export default async (ctx: Koa.Context) => {
const instance = await fetchMeta(true);
- // Verify recaptcha
+ // Verify *Captcha
// ただしテスト時はこの機構は障害となるため無効にする
- if (process.env.NODE_ENV !== 'test' && instance.enableRecaptcha && instance.recaptchaSecretKey) {
- recaptcha.init({
- secret_key: instance.recaptchaSecretKey
- });
+ if (process.env.NODE_ENV !== 'test') {
+ if (instance.enableHcaptcha && instance.hcaptchaSecretKey) {
+ const success = await verify(instance.hcaptchaSecretKey, body['hcaptcha-response']).then(
+ ({ success }) => success,
+ () => false,
+ );
+
+ if (!success) {
+ ctx.throw(400, 'hcaptcha-failed');
+ }
+ }
+
+ if (instance.enableRecaptcha && instance.recaptchaSecretKey) {
+ recaptcha.init({
+ secret_key: instance.recaptchaSecretKey
+ });
- const success = await recaptcha(body['g-recaptcha-response']);
+ const success = await recaptcha(body['g-recaptcha-response']);
- if (!success) {
- ctx.throw(400, 'recaptcha-failed');
+ if (!success) {
+ ctx.throw(400, 'recaptcha-failed');
+ }
}
}
diff --git a/src/server/nodeinfo.ts b/src/server/nodeinfo.ts
index 2ff924e68d..442e946df3 100644
--- a/src/server/nodeinfo.ts
+++ b/src/server/nodeinfo.ts
@@ -65,6 +65,7 @@ const nodeinfo2 = async () => {
disableRegistration: meta.disableRegistration,
disableLocalTimeline: meta.disableLocalTimeline,
disableGlobalTimeline: meta.disableGlobalTimeline,
+ enableHcaptcha: meta.enableHcaptcha,
enableRecaptcha: meta.enableRecaptcha,
maxNoteTextLength: meta.maxNoteTextLength,
enableTwitterIntegration: meta.enableTwitterIntegration,
diff --git a/src/server/web/views/info.pug b/src/server/web/views/info.pug
index 992e652a60..4553d2e2b9 100644
--- a/src/server/web/views/info.pug
+++ b/src/server/web/views/info.pug
@@ -107,6 +107,9 @@ html
th Registration
td= !meta.disableRegistration ? 'yes' : 'no'
tr
+ th hCaptcha enabled
+ td= meta.enableHcaptcha ? 'enabled' : 'disabled'
+ tr
th reCAPTCHA enabled
td= meta.enableRecaptcha ? 'enabled' : 'disabled'
tr