diff options
| author | かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com> | 2024-07-30 20:30:41 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-30 20:30:41 +0900 |
| commit | 8b163cd3fbae0cac43c79807ef891532de740797 (patch) | |
| tree | db178118b957ee998c2ff7110a51be09cdeca49d /packages/frontend/src/scripts | |
| parent | Update about-misskey.vue (diff) | |
| download | misskey-8b163cd3fbae0cac43c79807ef891532de740797.tar.gz misskey-8b163cd3fbae0cac43c79807ef891532de740797.tar.bz2 misskey-8b163cd3fbae0cac43c79807ef891532de740797.zip | |
fix(frontend): ドライブの音声が再生できない場合の処理を追加 (#14073)
* fix(frontend): ドライブの音声が再生できない場合の処理を追加
* Update Changelog
* fix lint
* Update packages/frontend/src/scripts/sound.ts
* lint
* Update sound.ts
* fix merge mistakes
* use shorthand operator
---------
Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Diffstat (limited to 'packages/frontend/src/scripts')
| -rw-r--r-- | packages/frontend/src/scripts/sound.ts | 35 |
1 files changed, 24 insertions, 11 deletions
diff --git a/packages/frontend/src/scripts/sound.ts b/packages/frontend/src/scripts/sound.ts index 814e080811..05f82fce7d 100644 --- a/packages/frontend/src/scripts/sound.ts +++ b/packages/frontend/src/scripts/sound.ts @@ -124,23 +124,33 @@ export async function loadAudio(url: string, options?: { useCache?: boolean; }) */ export function playMisskeySfx(operationType: OperationType) { const sound = defaultStore.state[`sound_${operationType}`]; - playMisskeySfxFile(sound); + playMisskeySfxFile(sound).then((succeed) => { + if (!succeed && sound.type === '_driveFile_') { + // ドライブファイルが存在しない場合はデフォルトのサウンドを再生する + const soundName = defaultStore.def[`sound_${operationType}`].default.type as Exclude<SoundType, '_driveFile_'>; + if (_DEV_) console.log(`Failed to play sound: ${sound.fileUrl}, so play default sound: ${soundName}`); + playMisskeySfxFileInternal({ + type: soundName, + volume: sound.volume, + }); + } + }); } /** * サウンド設定形式で指定された音声を再生する * @param soundStore サウンド設定 */ -export function playMisskeySfxFile(soundStore: SoundStore) { +export async function playMisskeySfxFile(soundStore: SoundStore): Promise<boolean> { // 連続して再生しない - if (!canPlay) return; + if (!canPlay) return false; // ユーザーアクティベーションが必要な場合はそれがない場合は再生しない - if ('userActivation' in navigator && !navigator.userActivation.hasBeenActive) return; + if ('userActivation' in navigator && !navigator.userActivation.hasBeenActive) return false; // サウンドがない場合は再生しない - if (soundStore.type === null || soundStore.type === '_driveFile_' && !soundStore.fileUrl) return; + if (soundStore.type === null || soundStore.type === '_driveFile_' && !soundStore.fileUrl) return false; canPlay = false; - playMisskeySfxFileInternal(soundStore).finally(() => { + return await playMisskeySfxFileInternal(soundStore).finally(() => { // ごく短時間に音が重複しないように setTimeout(() => { canPlay = true; @@ -148,19 +158,22 @@ export function playMisskeySfxFile(soundStore: SoundStore) { }); } -async function playMisskeySfxFileInternal(soundStore: SoundStore) { +async function playMisskeySfxFileInternal(soundStore: SoundStore): Promise<boolean> { if (soundStore.type === null || (soundStore.type === '_driveFile_' && !soundStore.fileUrl)) { - return; + return false; } const masterVolume = defaultStore.state.sound_masterVolume; if (isMute() || masterVolume === 0 || soundStore.volume === 0) { - return; + return true; // ミュート時は成功として扱う } const url = soundStore.type === '_driveFile_' ? soundStore.fileUrl : `/client-assets/sounds/${soundStore.type}.mp3`; - const buffer = await loadAudio(url); - if (!buffer) return; + const buffer = await loadAudio(url).catch(() => { + return undefined; + }); + if (!buffer) return false; const volume = soundStore.volume * masterVolume; createSourceNode(buffer, { volume }).soundSource.start(); + return true; } export async function playUrl(url: string, opts: { |