summaryrefslogtreecommitdiff
path: root/packages/backend/test
diff options
context:
space:
mode:
authorsyuilo <Syuilotan@yahoo.co.jp>2023-10-03 20:26:11 +0900
committerGitHub <noreply@github.com>2023-10-03 20:26:11 +0900
commit6277a5545c746fac15ee6b4fe58de2e354ed7fda (patch)
tree700b0d162795f03d644a15ba2375628d66f95d92 /packages/backend/test
parentUpdate about-misskey.vue (diff)
downloadmisskey-6277a5545c746fac15ee6b4fe58de2e354ed7fda.tar.gz
misskey-6277a5545c746fac15ee6b4fe58de2e354ed7fda.tar.bz2
misskey-6277a5545c746fac15ee6b4fe58de2e354ed7fda.zip
feat: improve tl performance (#11946)
* wip * wip * wip * wip * wip * wip * Update NoteCreateService.ts * wip * wip * wip * wip * Update NoteCreateService.ts * wip * Update NoteCreateService.ts * wip * Update user-notes.ts * wip * wip * wip * Update NoteCreateService.ts * wip * Update timeline.ts * Update timeline.ts * Update timeline.ts * Update timeline.ts * Update timeline.ts * wip * Update timelines.ts * Update timelines.ts * Update timelines.ts * wip * wip * wip * Update timelines.ts * Update misskey-js.api.md * Update timelines.ts * Update timelines.ts * wip * wip * wip * Update timelines.ts * wip * Update timelines.ts * wip * test * Update activitypub.ts * refactor: UserListJoining -> UserListMembership * Update NoteCreateService.ts * wip
Diffstat (limited to 'packages/backend/test')
-rw-r--r--packages/backend/test/e2e/renote-mute.ts8
-rw-r--r--packages/backend/test/e2e/timelines.ts701
-rw-r--r--packages/backend/test/e2e/user-notes.ts17
-rw-r--r--packages/backend/test/e2e/users.ts1
-rw-r--r--packages/backend/test/utils.ts10
5 files changed, 720 insertions, 17 deletions
diff --git a/packages/backend/test/e2e/renote-mute.ts b/packages/backend/test/e2e/renote-mute.ts
index c9e1ccc304..7d57ba17b6 100644
--- a/packages/backend/test/e2e/renote-mute.ts
+++ b/packages/backend/test/e2e/renote-mute.ts
@@ -6,7 +6,7 @@
process.env.NODE_ENV = 'test';
import * as assert from 'assert';
-import { signup, api, post, react, startServer, waitFire } from '../utils.js';
+import { signup, api, post, react, startServer, waitFire, sleep } from '../utils.js';
import type { INestApplicationContext } from '@nestjs/common';
import type * as misskey from 'misskey-js';
@@ -42,6 +42,9 @@ describe('Renote Mute', () => {
const carolRenote = await post(carol, { renoteId: bobNote.id });
const carolNote = await post(carol, { text: 'hi' });
+ // redisに追加されるのを待つ
+ await sleep(100);
+
const res = await api('/notes/local-timeline', {}, alice);
assert.strictEqual(res.status, 200);
@@ -56,6 +59,9 @@ describe('Renote Mute', () => {
const carolRenote = await post(carol, { renoteId: bobNote.id, text: 'kore' });
const carolNote = await post(carol, { text: 'hi' });
+ // redisに追加されるのを待つ
+ await sleep(100);
+
const res = await api('/notes/local-timeline', {}, alice);
assert.strictEqual(res.status, 200);
diff --git a/packages/backend/test/e2e/timelines.ts b/packages/backend/test/e2e/timelines.ts
new file mode 100644
index 0000000000..f4c7ffc82d
--- /dev/null
+++ b/packages/backend/test/e2e/timelines.ts
@@ -0,0 +1,701 @@
+/*
+ * SPDX-FileCopyrightText: syuilo and other misskey contributors
+ * SPDX-License-Identifier: AGPL-3.0-only
+ */
+
+process.env.NODE_ENV = 'test';
+process.env.FORCE_FOLLOW_REMOTE_USER_FOR_TESTING = 'true';
+
+import * as assert from 'assert';
+import { signup, api, post, react, startServer, waitFire, sleep, uploadUrl } from '../utils.js';
+import type { INestApplicationContext } from '@nestjs/common';
+import type * as misskey from 'misskey-js';
+
+let app: INestApplicationContext;
+
+beforeAll(async () => {
+ app = await startServer();
+}, 1000 * 60 * 2);
+
+afterAll(async () => {
+ await app.close();
+});
+
+describe('Timelines', () => {
+ describe('Home TL', () => {
+ test.concurrent('自分の visibility: followers なノートが含まれる', async () => {
+ const [alice] = await Promise.all([signup()]);
+
+ const aliceNote = await post(alice, { text: 'hi', visibility: 'followers' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === aliceNote.id), true);
+ assert.strictEqual(res.body.find((note: any) => note.id === aliceNote.id).text, 'hi');
+ });
+
+ test.concurrent('フォローしているユーザーのノートが含まれる', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi' });
+ const carolNote = await post(carol, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('フォローしているユーザーの visibility: followers なノートが含まれる', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'followers' });
+ const carolNote = await post(carol, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.find((note: any) => note.id === bobNote.id).text, 'hi');
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('withReplies: false でフォローしているユーザーの他人への返信が含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('withReplies: true でフォローしているユーザーの他人への返信が含まれる', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/following/update', { userId: bob.id, withReplies: true }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('withReplies: true でフォローしているユーザーの他人へのDM返信が含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/following/update', { userId: bob.id, withReplies: true }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id, visibility: 'specified', visibleUserIds: [carolNote.id] });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('withReplies: true でフォローしているユーザーの他人の visibility: followers な投稿への返信が含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/following/update', { userId: bob.id, withReplies: true }, alice);
+ const carolNote = await post(carol, { text: 'hi', visibility: 'followers' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('withReplies: true でフォローしているユーザーの行った別のフォローしているユーザーの visibility: followers な投稿への返信が含まれる', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/following/create', { userId: carol.id }, alice);
+ await api('/following/update', { userId: bob.id, withReplies: true }, alice);
+ const carolNote = await post(carol, { text: 'hi', visibility: 'followers' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), true);
+ assert.strictEqual(res.body.find((note: any) => note.id === carolNote.id).text, 'hi');
+ });
+
+ test.concurrent('withReplies: true でフォローしているユーザーの行った別のフォローしているユーザーの投稿への visibility: specified な返信が含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/following/create', { userId: carol.id }, alice);
+ await api('/following/update', { userId: bob.id, withReplies: true }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id, visibility: 'specified', visibleUserIds: [carolNote.id] });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), true);
+ });
+
+ test.concurrent('withReplies: false でフォローしているユーザーのそのユーザー自身への返信が含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote1 = await post(bob, { text: 'hi' });
+ const bobNote2 = await post(bob, { text: 'hi', replyId: bobNote1.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote1.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote2.id), true);
+ });
+
+ test.concurrent('自分の他人への返信が含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const bobNote = await post(bob, { text: 'hi' });
+ const aliceNote = await post(alice, { text: 'hi', replyId: bobNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === aliceNote.id), true);
+ });
+
+ test.concurrent('フォローしているユーザーの他人の投稿のリノートが含まれる', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { renoteId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('[withRenotes: false] フォローしているユーザーの他人の投稿のリノートが含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { renoteId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {
+ withRenotes: false,
+ }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('[withRenotes: false] フォローしているユーザーの他人の投稿の引用が含まれる', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', renoteId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {
+ withRenotes: false,
+ }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('フォローしているユーザーの他人への visibility: specified なノートが含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'specified', visibleUserIds: [carol.id] });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ });
+
+ test.concurrent('フォローしているユーザーが行ったミュートしているユーザーのリノートが含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/mute/create', { userId: carol.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', renoteId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('withReplies: true でフォローしているユーザーが行ったミュートしているユーザーの投稿への返信が含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/following/update', { userId: bob.id, withReplies: true }, alice);
+ await api('/mute/create', { userId: carol.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('フォローしているリモートユーザーのノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup({ host: 'example.com' })]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('フォローしているリモートユーザーの visibility: home なノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup({ host: 'example.com' })]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'home' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('[withFiles: true] フォローしているユーザーのファイル付きノートのみ含まれる', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const [bobFile, carolFile] = await Promise.all([
+ uploadUrl(bob, 'https://raw.githubusercontent.com/misskey-dev/assets/main/icon.png'),
+ uploadUrl(carol, 'https://raw.githubusercontent.com/misskey-dev/assets/main/icon.png'),
+ ]);
+ const bobNote1 = await post(bob, { text: 'hi' });
+ const bobNote2 = await post(bob, { fileIds: [bobFile.id] });
+ const carolNote1 = await post(carol, { text: 'hi' });
+ const carolNote2 = await post(carol, { fileIds: [carolFile.id] });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/timeline', { withFiles: true }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote1.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote2.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote1.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote2.id), false);
+ }, 1000 * 10);
+ });
+
+ describe('Local TL', () => {
+ test.concurrent('visibility: home なノートが含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ const carolNote = await post(carol, { text: 'hi', visibility: 'home' });
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/local-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('リモートユーザーのノートが含まれない', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup({ host: 'example.com' })]);
+
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/local-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ });
+
+ // 含まれても良いと思うけど実装が面倒なので含まれない
+ test.concurrent('フォローしているユーザーの visibility: home なノートが含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', {
+ userId: carol.id,
+ }, alice);
+ const carolNote = await post(carol, { text: 'hi', visibility: 'home' });
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/local-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('ミュートしているユーザーのノートが含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/mute/create', { userId: carol.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/local-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('フォローしているユーザーが行ったミュートしているユーザーのリノートが含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/mute/create', { userId: carol.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', renoteId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/local-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('withReplies: true でフォローしているユーザーが行ったミュートしているユーザーの投稿への返信が含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ await api('/following/update', { userId: bob.id, withReplies: true }, alice);
+ await api('/mute/create', { userId: carol.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/local-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === carolNote.id), false);
+ });
+
+ test.concurrent('[withFiles: true] ファイル付きノートのみ含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const file = await uploadUrl(bob, 'https://raw.githubusercontent.com/misskey-dev/assets/main/icon.png');
+ const bobNote1 = await post(bob, { text: 'hi' });
+ const bobNote2 = await post(bob, { fileIds: [file.id] });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/local-timeline', { withFiles: true }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote1.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote2.id), true);
+ }, 1000 * 10);
+ });
+
+ describe('Social TL', () => {
+ test.concurrent('ローカルユーザーのノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/hybrid-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('ローカルユーザーの visibility: home なノートが含まれない', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const bobNote = await post(bob, { text: 'hi', visibility: 'home' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/hybrid-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ });
+
+ test.concurrent('フォローしているローカルユーザーの visibility: home なノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'home' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/hybrid-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('リモートユーザーのノートが含まれない', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup({ host: 'example.com' })]);
+
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/local-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ });
+
+ test.concurrent('フォローしているリモートユーザーのノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup({ host: 'example.com' })]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/hybrid-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('フォローしているリモートユーザーの visibility: home なノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup({ host: 'example.com' })]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'home' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/hybrid-timeline', {}, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('[withFiles: true] ファイル付きノートのみ含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const file = await uploadUrl(bob, 'https://raw.githubusercontent.com/misskey-dev/assets/main/icon.png');
+ const bobNote1 = await post(bob, { text: 'hi' });
+ const bobNote2 = await post(bob, { fileIds: [file.id] });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/hybrid-timeline', { withFiles: true }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote1.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote2.id), true);
+ }, 1000 * 10);
+ });
+
+ describe('User List TL', () => {
+ test.concurrent('リスインしているフォローしていないユーザーのノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('リスインしているフォローしていないユーザーの visibility: home なノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'home' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ /* 未実装
+ test.concurrent('リスインしているフォローしていないユーザーの visibility: followers なノートが含まれない', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'followers' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ });
+ */
+
+ test.concurrent('リスインしているフォローしていないユーザーの visibility: followers なノートが含まれるが隠される', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'followers' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.find((note: any) => note.id === bobNote.id).text, null);
+ });
+
+ test.concurrent('リスインしているフォローしていないユーザーの他人への返信が含まれない', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), false);
+ });
+
+ test.concurrent('リスインしているフォローしていないユーザーのユーザー自身への返信が含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const bobNote1 = await post(bob, { text: 'hi' });
+ const bobNote2 = await post(bob, { text: 'hi', replyId: bobNote1.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote1.id), true);
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote2.id), true);
+ });
+
+ test.concurrent('withReplies: true でリスインしているフォローしていないユーザーの他人への返信が含まれる', async () => {
+ const [alice, bob, carol] = await Promise.all([signup(), signup(), signup()]);
+
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ await api('/users/lists/update-membership', { listId: list.id, userId: bob.id, withReplies: true }, alice);
+ const carolNote = await post(carol, { text: 'hi' });
+ const bobNote = await post(bob, { text: 'hi', replyId: carolNote.id });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('リスインしているフォローしているユーザーの visibility: home なノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'home' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ });
+
+ test.concurrent('リスインしているフォローしているユーザーの visibility: followers なノートが含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ await api('/following/create', { userId: bob.id }, alice);
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const bobNote = await post(bob, { text: 'hi', visibility: 'followers' });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote.id), true);
+ assert.strictEqual(res.body.find((note: any) => note.id === bobNote.id).text, 'hi');
+ });
+
+ test.concurrent('[withFiles: true] リスインしているユーザーのファイル付きノートのみ含まれる', async () => {
+ const [alice, bob] = await Promise.all([signup(), signup()]);
+
+ const list = await api('/users/lists/create', { name: 'list' }, alice).then(res => res.body);
+ await api('/users/lists/push', { listId: list.id, userId: bob.id }, alice);
+ const file = await uploadUrl(bob, 'https://raw.githubusercontent.com/misskey-dev/assets/main/icon.png');
+ const bobNote1 = await post(bob, { text: 'hi' });
+ const bobNote2 = await post(bob, { fileIds: [file.id] });
+
+ await sleep(100); // redisに追加されるのを待つ
+
+ const res = await api('/notes/user-list-timeline', { listId: list.id, withFiles: true }, alice);
+
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote1.id), false);
+ assert.strictEqual(res.body.some((note: any) => note.id === bobNote2.id), true);
+ }, 1000 * 10);
+ });
+
+ // TODO: リノートミュート済みユーザーのテスト
+ // TODO: ページネーションのテスト
+});
diff --git a/packages/backend/test/e2e/user-notes.ts b/packages/backend/test/e2e/user-notes.ts
index 121070787d..b5f00a6327 100644
--- a/packages/backend/test/e2e/user-notes.ts
+++ b/packages/backend/test/e2e/user-notes.ts
@@ -38,23 +38,10 @@ describe('users/notes', () => {
await app.close();
});
- test('ファイルタイプ指定 (jpg)', async () => {
+ test('withFiles', async () => {
const res = await api('/users/notes', {
userId: alice.id,
- fileType: ['image/jpeg'],
- }, alice);
-
- assert.strictEqual(res.status, 200);
- assert.strictEqual(Array.isArray(res.body), true);
- assert.strictEqual(res.body.length, 2);
- assert.strictEqual(res.body.some((note: any) => note.id === jpgNote.id), true);
- assert.strictEqual(res.body.some((note: any) => note.id === jpgPngNote.id), true);
- });
-
- test('ファイルタイプ指定 (jpg or png)', async () => {
- const res = await api('/users/notes', {
- userId: alice.id,
- fileType: ['image/jpeg', 'image/png'],
+ withFiles: true,
}, alice);
assert.strictEqual(res.status, 200);
diff --git a/packages/backend/test/e2e/users.ts b/packages/backend/test/e2e/users.ts
index 0f5d5f7344..53db1ac28a 100644
--- a/packages/backend/test/e2e/users.ts
+++ b/packages/backend/test/e2e/users.ts
@@ -133,6 +133,7 @@ describe('ユーザー', () => {
isMuted: user.isMuted ?? false,
isRenoteMuted: user.isRenoteMuted ?? false,
notify: user.notify ?? 'none',
+ withReplies: user.withReplies ?? false,
});
};
diff --git a/packages/backend/test/utils.ts b/packages/backend/test/utils.ts
index adc532bbe7..fae9018422 100644
--- a/packages/backend/test/utils.ts
+++ b/packages/backend/test/utils.ts
@@ -99,9 +99,17 @@ export const relativeFetch = async (path: string, init?: RequestInit | undefined
return await fetch(new URL(path, `http://127.0.0.1:${port}/`).toString(), init);
};
+function randomString(chars = 'abcdefghijklmnopqrstuvwxyz0123456789', length = 16) {
+ let randomString = '';
+ for (let i = 0; i < length; i++) {
+ randomString += chars[Math.floor(Math.random() * chars.length)];
+ }
+ return randomString;
+}
+
export const signup = async (params?: Partial<misskey.Endpoints['signup']['req']>): Promise<NonNullable<misskey.Endpoints['signup']['res']>> => {
const q = Object.assign({
- username: 'test',
+ username: randomString(),
password: 'test',
}, params);