summaryrefslogtreecommitdiff
path: root/packages/backend/src
diff options
context:
space:
mode:
authortamaina <tamaina@hotmail.co.jp>2023-01-06 22:34:50 +0900
committerGitHub <noreply@github.com>2023-01-06 22:34:50 +0900
commit5ec89ea0c3674a3b0b34f73cd576ee011530c9f0 (patch)
tree3a6861cce331bae49647c33eb60df728762e306f /packages/backend/src
parent13.0.0-beta.26 (diff)
downloadmisskey-5ec89ea0c3674a3b0b34f73cd576ee011530c9f0.tar.gz
misskey-5ec89ea0c3674a3b0b34f73cd576ee011530c9f0.tar.bz2
misskey-5ec89ea0c3674a3b0b34f73cd576ee011530c9f0.zip
カスタム絵文字にプロキシを復活 (#9481)
* wip * Revert "Update ClientServerService.ts" This reverts commit 88c64ece78db199d2f4685180511f2d6b84945d6. * Revert "disable custom emoji proxy temporary" This reverts commit 495d513efdb8b2a996287fd54ae5014832352616. * :v:
Diffstat (limited to 'packages/backend/src')
-rw-r--r--packages/backend/src/misc/is-mime-image.ts1
-rw-r--r--packages/backend/src/server/MediaProxyServerService.ts21
-rw-r--r--packages/backend/src/server/web/ClientServerService.ts5
3 files changed, 16 insertions, 11 deletions
diff --git a/packages/backend/src/misc/is-mime-image.ts b/packages/backend/src/misc/is-mime-image.ts
index 168a9a7af6..acf5c1ede3 100644
--- a/packages/backend/src/misc/is-mime-image.ts
+++ b/packages/backend/src/misc/is-mime-image.ts
@@ -3,6 +3,7 @@ import { FILE_TYPE_BROWSERSAFE } from '@/const.js';
const dictionary = {
'safe-file': FILE_TYPE_BROWSERSAFE,
'sharp-convertible-image': ['image/jpeg', 'image/png', 'image/gif', 'image/apng', 'image/vnd.mozilla.apng', 'image/webp', 'image/avif', 'image/svg+xml'],
+ 'sharp-animation-convertible-image': ['image/jpeg', 'image/png', 'image/gif', 'image/webp', 'image/avif', 'image/svg+xml'],
};
export const isMimeImage = (mime: string, type: keyof typeof dictionary): boolean => dictionary[type].includes(mime);
diff --git a/packages/backend/src/server/MediaProxyServerService.ts b/packages/backend/src/server/MediaProxyServerService.ts
index 4491a17545..5b76f15020 100644
--- a/packages/backend/src/server/MediaProxyServerService.ts
+++ b/packages/backend/src/server/MediaProxyServerService.ts
@@ -79,10 +79,18 @@ export class MediaProxyServerService {
const { mime, ext } = await this.fileInfoService.detectType(path);
const isConvertibleImage = isMimeImage(mime, 'sharp-convertible-image');
+ const isAnimationConvertibleImage = isMimeImage(mime, 'sharp-animation-convertible-image');
let image: IImage;
if ('emoji' in request.query && isConvertibleImage) {
- const data = await sharp(path, { animated: !('static' in request.query) })
+ if (!isAnimationConvertibleImage && !('static' in request.query)) {
+ image = {
+ data: fs.readFileSync(path),
+ ext,
+ type: mime,
+ };
+ } else {
+ const data = await sharp(path, { animated: !('static' in request.query) })
.resize({
height: 128,
withoutEnlargement: true,
@@ -90,11 +98,12 @@ export class MediaProxyServerService {
.webp(webpDefault)
.toBuffer();
- image = {
- data,
- ext: 'webp',
- type: 'image/webp',
- };
+ image = {
+ data,
+ ext: 'webp',
+ type: 'image/webp',
+ };
+ }
} else if ('static' in request.query && isConvertibleImage) {
image = await this.imageProcessingService.convertToWebp(path, 498, 280);
} else if ('preview' in request.query && isConvertibleImage) {
diff --git a/packages/backend/src/server/web/ClientServerService.ts b/packages/backend/src/server/web/ClientServerService.ts
index 461d1d489b..263b15cc5e 100644
--- a/packages/backend/src/server/web/ClientServerService.ts
+++ b/packages/backend/src/server/web/ClientServerService.ts
@@ -251,10 +251,6 @@ export class ClientServerService {
reply.header('Content-Security-Policy', 'default-src \'none\'; style-src \'unsafe-inline\'');
- // || emoji.originalUrl してるのは後方互換性のため(publicUrlはstringなので??はだめ)
- return await reply.redirect(301, emoji.publicUrl || emoji.originalUrl);
-
- /* https://github.com/misskey-dev/misskey/pull/9431#issuecomment-1373006446
const url = new URL('/proxy/emoji.webp', this.config.url);
// || emoji.originalUrl してるのは後方互換性のため(publicUrlはstringなので??はだめ)
url.searchParams.set('url', emoji.publicUrl || emoji.originalUrl);
@@ -265,7 +261,6 @@ export class ClientServerService {
301,
url.toString(),
);
- */
});
fastify.get<{ Params: { path: string } }>('/fluent-emoji/:path(.*)', async (request, reply) => {