diff options
| author | Kisaragi <48310258+KisaragiEffective@users.noreply.github.com> | 2024-09-15 15:13:46 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-15 15:13:46 +0900 |
| commit | 6b2072f4b1e6a191634b51b448442aaf57df5434 (patch) | |
| tree | 2c0c0c1edba7632cc0e867234777b61a918b0276 /packages/backend/src/server/api/endpoints/antennas | |
| parent | refactor(frontend): 非推奨の表現を改める (#14517) (diff) | |
| download | misskey-6b2072f4b1e6a191634b51b448442aaf57df5434.tar.gz misskey-6b2072f4b1e6a191634b51b448442aaf57df5434.tar.bz2 misskey-6b2072f4b1e6a191634b51b448442aaf57df5434.zip | |
fix(backend/antenna): キーワードが与えられなかった場合のエラーをApiErrorとして投げる (#14491)
* fix(backend/antenna): report validation failure as ApiError on update
* test(backend/antenna): reflect change in previous commit
* fix(backend/antenna): report validation failure as ApiError on create
* test(backend/antenna): reflect change in previous commit
* test(backend/antenna): semi
* test(backend/antenna): bring being spread parameters first in object literal
* chore: add CHANGELOG entry
---------
Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Diffstat (limited to 'packages/backend/src/server/api/endpoints/antennas')
| -rw-r--r-- | packages/backend/src/server/api/endpoints/antennas/create.ts | 8 | ||||
| -rw-r--r-- | packages/backend/src/server/api/endpoints/antennas/update.ts | 8 |
2 files changed, 14 insertions, 2 deletions
diff --git a/packages/backend/src/server/api/endpoints/antennas/create.ts b/packages/backend/src/server/api/endpoints/antennas/create.ts index 577b9e1b1f..e0c8ddcc84 100644 --- a/packages/backend/src/server/api/endpoints/antennas/create.ts +++ b/packages/backend/src/server/api/endpoints/antennas/create.ts @@ -34,6 +34,12 @@ export const meta = { code: 'TOO_MANY_ANTENNAS', id: 'faf47050-e8b5-438c-913c-db2b1576fde4', }, + + emptyKeyword: { + message: 'Either keywords or excludeKeywords is required.', + code: 'EMPTY_KEYWORD', + id: '53ee222e-1ddd-4f9a-92e5-9fb82ddb463a', + }, }, res: { @@ -87,7 +93,7 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- ) { super(meta, paramDef, async (ps, me) => { if (ps.keywords.flat().every(x => x === '') && ps.excludeKeywords.flat().every(x => x === '')) { - throw new Error('either keywords or excludeKeywords is required.'); + throw new ApiError(meta.errors.emptyKeyword); } const currentAntennasCount = await this.antennasRepository.countBy({ diff --git a/packages/backend/src/server/api/endpoints/antennas/update.ts b/packages/backend/src/server/api/endpoints/antennas/update.ts index 0c30bca9e0..10f26b1912 100644 --- a/packages/backend/src/server/api/endpoints/antennas/update.ts +++ b/packages/backend/src/server/api/endpoints/antennas/update.ts @@ -32,6 +32,12 @@ export const meta = { code: 'NO_SUCH_USER_LIST', id: '1c6b35c9-943e-48c2-81e4-2844989407f7', }, + + emptyKeyword: { + message: 'Either keywords or excludeKeywords is required.', + code: 'EMPTY_KEYWORD', + id: '721aaff6-4e1b-4d88-8de6-877fae9f68c4', + }, }, res: { @@ -85,7 +91,7 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- super(meta, paramDef, async (ps, me) => { if (ps.keywords && ps.excludeKeywords) { if (ps.keywords.flat().every(x => x === '') && ps.excludeKeywords.flat().every(x => x === '')) { - throw new Error('either keywords or excludeKeywords is required.'); + throw new ApiError(meta.errors.emptyKeyword); } } // Fetch the antenna |