summaryrefslogtreecommitdiff
path: root/packages/backend/src/core
diff options
context:
space:
mode:
authorsyuilo <4439005+syuilo@users.noreply.github.com>2024-09-28 18:15:32 +0900
committerGitHub <noreply@github.com>2024-09-28 18:15:32 +0900
commitf0d0cd2e5042fb30cf3ef1c2717540391ee97aac (patch)
tree13fd1980e127ac4f762ea7a9e6d4bf73fac8a888 /packages/backend/src/core
parentMerge branch 'develop' of https://github.com/misskey-dev/misskey into develop (diff)
downloadmisskey-f0d0cd2e5042fb30cf3ef1c2717540391ee97aac.tar.gz
misskey-f0d0cd2e5042fb30cf3ef1c2717540391ee97aac.tar.bz2
misskey-f0d0cd2e5042fb30cf3ef1c2717540391ee97aac.zip
wip (#14643)
Diffstat (limited to 'packages/backend/src/core')
-rw-r--r--packages/backend/src/core/UtilityService.ts19
-rw-r--r--packages/backend/src/core/activitypub/ApInboxService.ts4
-rw-r--r--packages/backend/src/core/activitypub/ApResolverService.ts2
-rw-r--r--packages/backend/src/core/activitypub/models/ApNoteService.ts3
4 files changed, 23 insertions, 5 deletions
diff --git a/packages/backend/src/core/UtilityService.ts b/packages/backend/src/core/UtilityService.ts
index 94729250a6..86082ccdcd 100644
--- a/packages/backend/src/core/UtilityService.ts
+++ b/packages/backend/src/core/UtilityService.ts
@@ -10,12 +10,16 @@ import RE2 from 're2';
import { DI } from '@/di-symbols.js';
import type { Config } from '@/config.js';
import { bindThis } from '@/decorators.js';
+import { MiMeta } from '@/models/Meta.js';
@Injectable()
export class UtilityService {
constructor(
@Inject(DI.config)
private config: Config,
+
+ @Inject(DI.meta)
+ private meta: MiMeta,
) {
}
@@ -105,4 +109,19 @@ export class UtilityService {
if (host == null) return null;
return toASCII(host.toLowerCase());
}
+
+ @bindThis
+ public isFederationAllowedHost(host: string): boolean {
+ if (this.meta.federation === 'none') return false;
+ if (this.meta.federation === 'specified' && !this.meta.federationHosts.some(x => `.${host.toLowerCase()}`.endsWith(`.${x}`))) return false;
+ if (this.isBlockedHost(this.meta.blockedHosts, host)) return false;
+
+ return true;
+ }
+
+ @bindThis
+ public isFederationAllowedUri(uri: string): boolean {
+ const host = this.extractDbHost(uri);
+ return this.isFederationAllowedHost(host);
+ }
}
diff --git a/packages/backend/src/core/activitypub/ApInboxService.ts b/packages/backend/src/core/activitypub/ApInboxService.ts
index 90da032895..376c9c0151 100644
--- a/packages/backend/src/core/activitypub/ApInboxService.ts
+++ b/packages/backend/src/core/activitypub/ApInboxService.ts
@@ -290,8 +290,8 @@ export class ApInboxService {
return;
}
- // アナウンス先をブロックしてたら中断
- if (this.utilityService.isBlockedHost(this.meta.blockedHosts, this.utilityService.extractDbHost(uri))) return;
+ // アナウンス先が許可されているかチェック
+ if (!this.utilityService.isFederationAllowedUri(uri)) return;
const unlock = await this.appLockService.getApLock(uri);
diff --git a/packages/backend/src/core/activitypub/ApResolverService.ts b/packages/backend/src/core/activitypub/ApResolverService.ts
index fdef7a8ffd..ca35608d9b 100644
--- a/packages/backend/src/core/activitypub/ApResolverService.ts
+++ b/packages/backend/src/core/activitypub/ApResolverService.ts
@@ -93,7 +93,7 @@ export class Resolver {
return await this.resolveLocal(value);
}
- if (this.utilityService.isBlockedHost(this.meta.blockedHosts, host)) {
+ if (!this.utilityService.isFederationAllowedHost(host)) {
throw new Error('Instance is blocked');
}
diff --git a/packages/backend/src/core/activitypub/models/ApNoteService.ts b/packages/backend/src/core/activitypub/models/ApNoteService.ts
index 00acb19a0f..2d333b3634 100644
--- a/packages/backend/src/core/activitypub/models/ApNoteService.ts
+++ b/packages/backend/src/core/activitypub/models/ApNoteService.ts
@@ -336,8 +336,7 @@ export class ApNoteService {
public async resolveNote(value: string | IObject, options: { sentFrom?: URL, resolver?: Resolver } = {}): Promise<MiNote | null> {
const uri = getApId(value);
- // ブロックしていたら中断
- if (this.utilityService.isBlockedHost(this.meta.blockedHosts, this.utilityService.extractDbHost(uri))) {
+ if (!this.utilityService.isFederationAllowedUri(uri)) {
throw new StatusError('blocked host', 451);
}