enable and fix no-unused-vars and no-async-promise-executor (#17070)

* dev: set --no-bail for lint task

* lint: enable no-async-promise-executor lint and fix them

* lint: enable no-unused-vars with allowing _ prefix

* lint: fix semi

1 files changed, 10 insertions, 12 deletions

diff --git a/packages/backend/scripts/check_connect.js b/packages/backend/scripts/check_connect.js
index d2f38aedb3..a1cb839303 100644
--- a/packages/backend/scripts/check_connect.js
+++ b/packages/backend/scripts/check_connect.js
@@ -16,24 +16,22 @@ async function connectToPostgres() {
 }
 
 async function connectToRedis(redisOptions) {
-	return await new Promise(async (resolve, reject) => {
-		const redis = new Redis({
+	let redis;
+	try {
+		redis = new Redis({
 			...redisOptions,
 			lazyConnect: true,
 			reconnectOnError: false,
 			showFriendlyErrorStack: true,
 		});
-		redis.on('error', e => reject(e));
 
-		try {
-			await redis.connect();
-			resolve();
-		} catch (e) {
-			reject(e);
-		} finally {
-			redis.disconnect(false);
-		}
-	});
+		await Promise.race([
+			new Promise((_, reject) => redis.on('error', e => reject(e))),
+			redis.connect(),
+		]);
+	} finally {
+		redis.disconnect(false);
+	}
 }
 
 // If not all of these are defined, the default one gets reused.