summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorかっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>2025-01-08 19:35:09 +0900
committerGitHub <noreply@github.com>2025-01-08 10:35:09 +0000
commit55713fcd657983add090a7788c6ffd984cbbd15f (patch)
tree4a285d2d3177054b8cd3658adcd0da4a51b157af
parentfix(frontend-embed): localeのバージョンチェックが抜けており... (diff)
downloadmisskey-55713fcd657983add090a7788c6ffd984cbbd15f.tar.gz
misskey-55713fcd657983add090a7788c6ffd984cbbd15f.tar.bz2
misskey-55713fcd657983add090a7788c6ffd984cbbd15f.zip
fix(backend): apOrHtml Constraintが正しく評価されない問題を修正 (#15213)
* fix(backend/ActivityPubServerService): apOrHtml Constraintが正しく評価されない問題を修正 (MisskeyIO#869) * Update Changelog * indent --------- Co-authored-by: あわわわとーにゅ <17376330+u1-liquid@users.noreply.github.com>
-rw-r--r--CHANGELOG.md2
-rw-r--r--packages/backend/src/server/ActivityPubServerService.ts4
2 files changed, 4 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 24b5f6e661..fd8eaf00e8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -30,6 +30,8 @@
(Cherry-picked from https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/737)
- Fix: ロックダウンされた期間指定のノートがStreaming経由でLTLに出現するのを修正 ( #15200 )
- Fix: disableClustering設定時の初期化ロジックを調整( #15223 )
+- Fix: ActivityPubリクエストかどうかの判定が正しくない問題を修正
+ (Cherry-picked from https://github.com/MisskeyIO/misskey/pull/869)
## 2024.11.0
diff --git a/packages/backend/src/server/ActivityPubServerService.ts b/packages/backend/src/server/ActivityPubServerService.ts
index f34f6583d3..8c4b13a40a 100644
--- a/packages/backend/src/server/ActivityPubServerService.ts
+++ b/packages/backend/src/server/ActivityPubServerService.ts
@@ -519,8 +519,8 @@ export class ActivityPubServerService {
},
deriveConstraint(request: IncomingMessage) {
const accepted = accepts(request).type(['html', ACTIVITY_JSON, LD_JSON]);
- const isAp = typeof accepted === 'string' && !accepted.match(/html/);
- return isAp ? 'ap' : 'html';
+ if (accepted === false) return null;
+ return accepted !== 'html' ? 'ap' : 'html';
},
});