diff options
| author | Eiichi Yoshikawa <edo@bari-ikutsu.com> | 2024-07-16 08:38:42 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-16 08:38:42 +0900 |
| commit | 3b075c9c441e8fe2d7446a7201cd1950437ba0b6 (patch) | |
| tree | 75868b429c8379a3da6ea890250c751be0f7f2db | |
| parent | fix: CHANGELOG.mdの記載に漏れがあったのを修正 (#14220) (diff) | |
| download | misskey-3b075c9c441e8fe2d7446a7201cd1950437ba0b6.tar.gz misskey-3b075c9c441e8fe2d7446a7201cd1950437ba0b6.tar.bz2 misskey-3b075c9c441e8fe2d7446a7201cd1950437ba0b6.zip | |
fix(frontend): MkSignin.vueのcredentialRequestからReactivityを削除 (#14223)
* Remove reactivity from credentialRequest in MkSignin.vue
* Update Changelog
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rw-r--r-- | packages/frontend/src/components/MkSignin.vue | 10 |
2 files changed, 6 insertions, 5 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 058aa33719..53bf9233fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ - Fix: テーマプレビューが見れない問題を修正 - Fix: ショートカットキーが連打できる問題を修正 (Cherry-picked from https://github.com/taiyme/misskey/pull/234) +- Fix: MkSignin.vueのcredentialRequestからReactivityを削除（ProxyがPasskey認証処理に渡ることを避けるため） ### Server - Feat: レートリミット制限に引っかかったときに`Retry-After`ヘッダーを返すように (#13949) diff --git a/packages/frontend/src/components/MkSignin.vue b/packages/frontend/src/components/MkSignin.vue index a123bbddc6..781145e1bc 100644 --- a/packages/frontend/src/components/MkSignin.vue +++ b/packages/frontend/src/components/MkSignin.vue @@ -87,7 +87,7 @@ const host = ref(toUnicode(configHost)); const totpLogin = ref(false); const isBackupCode = ref(false); const queryingKey = ref(false); -const credentialRequest = ref<CredentialRequestOptions | null>(null); +let credentialRequest: CredentialRequestOptions | null = null; const emit = defineEmits<{ (ev: 'login', v: any): void; @@ -122,14 +122,14 @@ function onLogin(res: any): Promise<void> | void { } async function queryKey(): Promise<void> { - if (credentialRequest.value == null) return; + if (credentialRequest == null) return; queryingKey.value = true; - await webAuthnRequest(credentialRequest.value) + await webAuthnRequest(credentialRequest) .catch(() => { queryingKey.value = false; return Promise.reject(null); }).then(credential => { - credentialRequest.value = null; + credentialRequest = null; queryingKey.value = false; signing.value = true; return misskeyApi('signin', { @@ -160,7 +160,7 @@ function onSubmit(): void { }).then(res => { totpLogin.value = true; signing.value = false; - credentialRequest.value = parseRequestOptionsFromJSON({ + credentialRequest = parseRequestOptionsFromJSON({ publicKey: res, }); }) |