diff options
| author | Lars Hjemli <hjemli@gmail.com> | 2008-03-17 23:13:16 +0100 | 
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2008-03-17 23:51:47 +0100 | 
| commit | e01f1403b9b501c563b1fe0e0052460a95945528 (patch) | |
| tree | eff9fd11272714db70bf2ac7116511f03d800af6 /ui-patch.c | |
| parent | Use GIT-1.5.4.4 (diff) | |
| download | cgit-e01f1403b9b501c563b1fe0e0052460a95945528.tar.gz cgit-e01f1403b9b501c563b1fe0e0052460a95945528.tar.bz2 cgit-e01f1403b9b501c563b1fe0e0052460a95945528.zip | |
Fix segfault in patch view for root commit
The code for patch view assumed the current commit would always have a parent,
which made cgit segfault when that wasn't the case.
This fixes the bug and adds a test-script for patch view which includes a test
for the inital commit.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | ui-patch.c | 6 | 
1 files changed, 5 insertions, 1 deletions
| @@ -88,7 +88,11 @@ void cgit_print_patch(char *hex, struct cacheitem *item)  		return;  	}  	info = cgit_parse_commit(commit); -	hashcpy(old_sha1, commit->parents->item->object.sha1); + +	if (commit->parents && commit->parents->item) +		hashcpy(old_sha1, commit->parents->item->object.sha1); +	else +		hashclr(old_sha1);  	patchname = fmt("%s.patch", sha1_to_hex(sha1));  	cgit_print_snapshot_start("text/plain", patchname, item); | 
