cgit, branch jk/collapsible-sections

ui-repolist: Allow sections to be collapsible

2016-10-01T10:51:07Z

The index page can be difficult to navigate for really large git servers. This change allows a configuration like: section-collapse=people section-collapse=tests And an index page would only display the "people" and "tests" section headers entries (not their repos) with a hyperlink that can be used to drill down into each section. Additionally the boolean logic around displaying sections in ui-repolist.c was simplified to eliminate an impossible condition. Signed-off-by: Andy Doan Reviewed-by: John Keeping Signed-off-by: John Keeping

ui-repolist: provide hyperlinks on section names

2016-10-01T10:50:13Z

This makes it easier to traverse into a section of git repositories. Signed-off-by: Andy Doan Signed-off-by: John Keeping

ui-tree: remove a fixed size buffer

2016-10-01T10:46:55Z

As libgit.a moves away from using fixed size buffers, there is no guarantee that PATH_MAX is sufficient for all of the paths in a Git tree, so we should use a dynamically sized buffer here. Coverity-Id: 141884 Signed-off-by: John Keeping

ui-tag: clean up taginfo

2016-10-01T10:46:55Z

Free the taginfo when we're done with it. Also reduce the scope of a couple of variables so that it's clear that this is the only path that uses the taginfo structure. Coverity-Id: 141883 Signed-off-by: John Keeping

shared: make cgit_free_taginfo() public

2016-10-01T10:46:55Z

We will use this function from ui-tag.c in the next patch. Signed-off-by: John Keeping

shared: remove return value from cgit_free_commitinfo()

2016-10-01T10:46:55Z

This return value is never used and the function always returns NULL. Signed-off-by: John Keeping

tree: allow skipping through single-child trees

2016-10-01T10:45:17Z

If we have only a single element in a directory (for example in Java package paths), display multiple directories in one go so that it is possible to navigate directly to the first directory that contains either files or multiple directories. Signed-off-by: John Keeping

ui-ssdiff: fix decl-after-statement warnings

2016-10-01T10:43:45Z

git.git's coding style avoids decl-after-statement and we generally try to follow it but a few warnings have crept in recently. Fix the one in ui-ssdiff.c Signed-off-by: John Keeping

ui-shared: fix decl-after-statement warnings

2016-10-01T10:43:45Z

git.git's coding style avoids decl-after-statement and we generally try to follow it but a few warnings have crept in recently. Fix the ones in ui-shared.c Signed-off-by: John Keeping

configfile: fix EOF handling

2016-10-01T10:43:33Z

Currently we can end up passing EOF to isspace(), which is in fact libgit's sane_isspace which does: ((sane_ctype[(unsigned char)(x)] & (GIT_SPACE)) != 0) It is very unlikely that EOF cast to "unsigned char" will end up in a character that has the GIT_SPACE bit set, but the standard only requires that EOF be a negative integer, so it could access any value in the sane_ctype array. If it does end up returning true for isspace() then this loop will never terminate, so handle EOF as a special value in the same way as the other loops in this function. Signed-off-by: John Keeping